Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wrong dependency resolution #1698

Closed
GiladShoham opened this issue Jun 2, 2019 · 1 comment
Closed

wrong dependency resolution #1698

GiladShoham opened this issue Jun 2, 2019 · 1 comment

Comments

@GiladShoham
Copy link
Member

Expected Behavior

The bit.envs/internal/typescript-base-compiler dependency of react-typescript and typescript should be 3.5.0 and not 1.0.0

Actual Behavior

The dependency is shown as 1.0.0

Steps to Reproduce the Problem

  1. clone https://github.com/teambit/bit.envs
  2. move to a37022d105e6ac94836ca00ee99d678f9a4eed0f hash
  3. install everything needed
  4. run bit show compilers/typescript
  5. see the internal/typescript-base-compiler dependency version

I have no idea where version 1.0.0 is coming from. This version has never existed. It's a new component I've just tagged in v3.5.0 and export.
After tagging both react-typescript and typescript, they are still modified, now show the dependency with the correct version

Specifications

bit version : 14.1.2-dev.6
node version : v8.10.0
npm version : 6.8.0
yarn version : 1.9.4
platform : darwin

davidfirst added a commit that referenced this issue Jun 3, 2019
…ve rootDir, otherwise, the symlinks are generated from workspace root and as a result, the version resolution uses the root package.json version, which is wrong
davidfirst added a commit that referenced this issue Jun 3, 2019
…requires authored component. added e2e-tests. fix generated main path of package.json in node_modules for author
@davidfirst
Copy link
Member

This happens when an imported component requires an authored component and the dist directory is set to be outside of the components dir.
The link-generator used to generate incorrect symlinks from the workspace root to the imported component. As a result, the dependency-version-resolution used the package.json of the workspace to conclude the version of the authored component.

This has been fixed to not generate such symlinks as they are not needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants