Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to skip auto-tag in bit tag command #2066

Closed
DeyLak opened this issue Oct 14, 2019 · 9 comments
Closed

Option to skip auto-tag in bit tag command #2066

DeyLak opened this issue Oct 14, 2019 · 9 comments

Comments

@DeyLak
Copy link

DeyLak commented Oct 14, 2019

Description

I suggest to have an option for bit tag command, that allows you to tag only the component, you specified, and not tagging components, that depends on this one.

Describe the solution you'd like

I think, it could look something like: bit tag my-component --ignore-dependants or bit tag my-component -D

Additional context

I found myself running bit untag command quite frequently for these auto-tagged dependencies, cause, they might not be in the state I wanted to tag yet.

@davidfirst
Copy link
Member

@DeyLak , sounds like a legit use-case. In fact, I came across a similar case myself recently.
I suggest --skip-auto-tag for this feature. @GiladShoham , @itaymendel ?

@GiladShoham
Copy link
Member

I and @itaymendel or @ranm8 spoke about it few weeks ago.
I definitely think we should add this.

@davidfirst
Copy link
Member

Implemented. The new flag name is --skip-auto-tag.

@itaymendel
Copy link
Contributor

Hi @DeyLak ,

Can you please describe the workflow that caused you to the untag for the auto-tag, and why would you want to skip the auto-tag mechanism?

For now, I suggest we'll introduce the feature as experimental, as I would want to try and play with it and see how it feels. I think that a better approach would be to (a) improve control of the component's dependency graph and (b) improve control of component changes.

@itaymendel itaymendel reopened this Oct 23, 2019
@DeyLak
Copy link
Author

DeyLak commented Oct 23, 2019

@itaymendel My workflow is something like this:

  1. I have workspace with components A and B
  2. I'm working on component A
  3. Changes in component A requires changes in component B(dependency of component A)
  4. I change component B and tag it. This causes component A to be tagged automatically.
  5. Interesting behaviour(don't know, if this is intended to work like this) that component A is only tagged with the new version of component B, but not with my code changes, so it is still shown as modified in bit status
  6. I don't want that in-between version to occur, it might be even broken(if changes in comp B is breaking changes)
  7. I untag comp A and continue my work on it
  8. I tag comp A, when it's ready

@GiladShoham
Copy link
Member

@DeyLak Just a side note about number 4 -
This is by design. The auto tag will only tag the dependency change (the rationale - we don't know if your changes in the source code are related or not, and if they are ready to be tagged or not).
however if they are related and ready, you can tag a and b together (or tag --all), this will result tagging the dependency changes along with the source code changes of A).
(I'll make sure to add something about it in the docs)

@GiladShoham GiladShoham modified the milestones: 14.5.0, 14.4.2 Oct 23, 2019
@itaymendel
Copy link
Contributor

itaymendel commented Oct 23, 2019

@DeyLak , so you still want Component B to depend on the new version of Component A?

For example, Componet A was in version 1.0.0 and you have tagged a new version - 1.1.0.
In this case - which version of Component A should Component B depend on?

@DeyLak
Copy link
Author

DeyLak commented Oct 23, 2019

@itaymendel Comp B is a dependency of Comp A, not vice versa.
Here is my example with versions:

  1. [email protected] depends on [email protected]
  2. Tag [email protected] -> auto tag [email protected] (with dependency of [email protected])
  3. Untag CompA
  4. Work on CompA with dependency of [email protected] and tag [email protected]

@itaymendel
Copy link
Contributor

resovled in v15

We'll start rolling out v15 of Bit this week, please reach out to me privately on the public slack community for a sneak peek and getting early access to it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants