Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save direct dependency in package.json with relative path #515

Closed
davidfirst opened this issue Jan 1, 2018 · 0 comments
Closed

save direct dependency in package.json with relative path #515

davidfirst opened this issue Jan 1, 2018 · 0 comments

Comments

@davidfirst
Copy link
Member

davidfirst commented Jan 1, 2018

Similar to #506 but with direct dependency.
For example, a component is-string depends on is-type. By default, is-type is saved as an NPM package. As such, the package.json of is-string will have a dependency, something like: "@bit/is-type": "0.0.1".
To update is-type, a user needs to run 'bit import is-type'. During the import, we fix the links and point is-type dependency of is-string to newly imported is-type.
However, in case the user wants to publish his package, it won't work. The npm installation of is-string will save is-type as a package and won't point to the imported is-type.
The solution is to update the package.json of 'is-string' and change the is-type entry from a package to a relative path inside the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants