revert onboarding job #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sarah Funkhouser <[email protected]>
golanglemonade
requested review from
matoszz,
LemonAid711 and
theopenlane-bender
matoszz
approved these changes
Feb 20, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
jobs dependent on
corecannot be defined here; they will need to be defined in the core repo and than configured here (which is something I was trying to decide originally is where to define these jobs)The problem right now is the core depends on riverboat (to insert jobs) and with this here, riverboat then depends on core. So if you make a breaking change to a schema, the import will be broken and nothing will build (fun times :-D)
I'll set this back up in core and then configure here when its ready.