Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add env guard middleware #4370

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Feb 21, 2025

What's the problem?

What are the alternatives?

  • Running Metabase on pizzas (bad - more CI time for little gain)
  • Running Metabase locally, syncing data (also not great - nice to optionally do it, but making it a requirement isn't ideal)
  • Ignoring this, letting it fail (maybe!)

What's the solution?

Very open to ideas here - the current implementation will stop Metabase routes from being accessible locally and on Pizzas.

@DafyddLlyr DafyddLlyr force-pushed the dp/env-guard-middleware branch from 068038d to de9ae3f Compare February 21, 2025 17:50
@DafyddLlyr DafyddLlyr force-pushed the dp/env-guard-middleware branch from de9ae3f to a1d05d7 Compare February 21, 2025 17:52
Copy link

github-actions bot commented Feb 21, 2025

Pizza

Deployed fa2e689 to https://4370.planx.pizza.

Useful links:

@DafyddLlyr DafyddLlyr requested a review from a team February 21, 2025 18:17
@DafyddLlyr DafyddLlyr marked this pull request as ready for review February 21, 2025 18:17
@zz-hh-aa
Copy link
Collaborator

Thanks for looking into this!

One thing I've found useful is being able to hook up my local API to Metabase staging by putting staging vars in my local env files. I've been testing calls in development that way (currently using Insomnia). Not sure if this might be bad practice but being able to do this has been useful so far.

Might there be a way to have the env guard on Pizzas but not necessarily locally?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants