Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asking for 1.10 selects 1.1 #132

Closed
sbinet opened this issue Feb 17, 2018 · 11 comments
Closed

asking for 1.10 selects 1.1 #132

sbinet opened this issue Feb 17, 2018 · 11 comments

Comments

@sbinet
Copy link

sbinet commented Feb 17, 2018

with this .travis.yml file:

go:
  - 1.10

one gets 1.1:

Updating gimme
$ GIMME_OUTPUT="$(gimme 1.1 | tee -a $HOME/.bashrc)" && eval "$GIMME_OUTPUT"
go version go1.1 linux/amd64

to get 1.10, one has to write it like so:

go:
  - "1.10"

and just putting 1.10.x confuses gimme:

Updating gimme
$ GIMME_OUTPUT="$(gimme 1.10.x | tee -a $HOME/.bashrc)" && eval "$GIMME_OUTPUT"
I don't have any idea what to do with '1.10.x'.
  (using type 'auto')

could we have gimme understand that x.yy.z means any x.yy even if no patch release for x.yy was made yet ?

philipjkim added a commit to philipjkim/goreadability that referenced this issue Feb 17, 2018
- Go v1.10 will be supported on Travis soon - travis-ci/gimme#132
philipjkim added a commit to philipjkim/goreadability that referenced this issue Feb 17, 2018
- Go v1.10 will be supported on Travis soon - travis-ci/gimme#132
@BanzaiMan
Copy link
Contributor

BanzaiMan commented Feb 17, 2018

Do understand that YAML says 1.10 is a float equivalent to 1.1. It is distinct from a string "1.10". We bend over backwards in many places to accommodate this surprisingly common misconception, but sometimes we lag behind.

@sbinet
Copy link
Author

sbinet commented Feb 17, 2018

Yes, I understand that.
It surprised me but (in the sense that it caught me off guard) I understand.

What I am suggesting it is to make sure that '1.42.x' always works to pick up '1.42' even if '1.42.1' isn't even out :)

@jmank88
Copy link

jmank88 commented Feb 17, 2018

I don't think gimme understands x at all. IIRC that conversion is done before gimme is called. My memory if foggy, but we went through this last cycle: golang/dep#714 (comment)

@jmank88
Copy link

jmank88 commented Feb 17, 2018

Also, getting a green build that reads 1.10.x but that actually ran 1.9.1 is a very poor user experience. IMHO gimme should reject instead of choosing seeming randomly (we got different fallbacks for linux vs. osx).

@sbinet
Copy link
Author

sbinet commented Feb 17, 2018

If 1.10 is out and I write 1.10.x I'd expect to get 1.10.
If 1.10.2 is out and I write 1.10.x I'd expect to get 1.10.2.
And if I were to write 1.11.x now, I'd expect to get an error.

Right now, if I write 1.10.x, I get 1.7.4 on Linux. (That's probably something to report in another issue, though...)

@jmank88
Copy link

jmank88 commented Feb 17, 2018

Right now, if I write '1.10.x', I get 1.7.4 on Linux. (That's probably something to report in another issue, though...)

And 1.9.1 on OSX ;)

@krasi-georgiev
Copy link

krasi-georgiev commented Feb 17, 2018

+1 prometheus is using gimme and so far always using the 1.10.x format to avoid updating travis on every go minor change.

octo added a commit to octo/retry that referenced this issue Feb 17, 2018
@philpennock
Copy link
Contributor

At present, the .x is handled (only) by travis-ci. PR #130 adds .x directly to gimme and I can confirm that 1.10.x maps to 1.10 in that PR.

mcuadros added a commit to src-d/go-git that referenced this issue Feb 17, 2018
fujita added a commit to fujita/gobgp that referenced this issue Feb 18, 2018
drop 1.8 support also.

Note that ugly double quates are necessary

travis-ci/gimme#132

Signed-off-by: FUJITA Tomonori <[email protected]>
wkschwartz added a commit to wkschwartz/pigosat that referenced this issue Feb 18, 2018
fdelbos added a commit to hyperboloide/pdfgen that referenced this issue Feb 19, 2018
ncw added a commit to rclone/rclone that referenced this issue Feb 20, 2018
Note we have to put the version number in quotes to work around
travis-ci/gimme#132
ncw added a commit to rclone/rclone that referenced this issue Feb 20, 2018
Note we have to put the version number in quotes to work around
travis-ci/gimme#132
marten-seemann added a commit to quic-go/quic-go that referenced this issue Feb 21, 2018
The version numbers in the travis config are strings, not numbers.
See travis-ci/gimme#132.
mjs added a commit to jumptrading/influx-spout that referenced this issue Feb 21, 2018
... and use quotes to avoid undesirable YAML float conversion.

See also:
- travis-ci/gimme#132
- travis-ci/gimme#130
jcrussell added a commit to jcrussell/minimega that referenced this issue Feb 21, 2018
@philpennock
Copy link
Contributor

The gimme feature to handle 1.10.x is in the master branch, I've no idea when the folks over at Travis will cut a new release and push it to their boxes. nudge nudge :)

@BanzaiMan
Copy link
Contributor

gimme 1.10 should now install Go 1.10.

That go: 1.10 maps to Go 1.1 is a separate issue. See travis-ci/travis-ci#9247

@philpennock
Copy link
Contributor

(For clarification: gimme 1.10 has never installed Go 1.1, AFAIK. It has always done the right thing. The problems have been entirely with how one product parses config files before things reach gimme. I've fixed a bunch of gimme bugs exposed around 1.10 but they're not anything which would have caused the wrong version to be installed.)

im-kulikov added a commit to im-kulikov/go-clickhouse that referenced this issue Feb 24, 2018
im-kulikov added a commit to im-kulikov/dbr that referenced this issue Feb 24, 2018
mariusae added a commit to grailbio/reflow that referenced this issue Feb 27, 2018
kkentzo pushed a commit to kkentzo/mockit that referenced this issue Jul 31, 2018
imcom pushed a commit to imcom/gobgp that referenced this issue Oct 23, 2018
drop 1.8 support also.

Note that ugly double quates are necessary

travis-ci/gimme#132

Signed-off-by: FUJITA Tomonori <[email protected]>
traidare pushed a commit to traidare/go-git that referenced this issue Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants