Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tspawnat on julia 1.7+ by making the task sticky #33

Merged
merged 7 commits into from
Feb 1, 2022

Conversation

IanButterworth
Copy link
Collaborator

@IanButterworth IanButterworth commented Jan 31, 2022

Fixes #32

I wasn't sure of the implication of setting sticky = true on < v1.7, so I played safe and left that as-is

cc. @Octogonapus @carstenbauer

@IanButterworth
Copy link
Collaborator Author

IanButterworth commented Jan 31, 2022

@tro3 I also noticed that there's no CI set up so I added github actions.

Would you mind approving the CI run, or better yet, changing the (annoying) github default to run CI for non-new github users

(I'd also be happy to help as a collaborator on the repo)

@tro3
Copy link
Owner

tro3 commented Feb 1, 2022

@IanButterworth - will do to both. I find myself out of the Julia domain nowadays, but I will be keeping up to date. But help is always appreciated. :-)

@IanButterworth
Copy link
Collaborator Author

Ok. Seems like CI is set up now. I can merge and release if you like @tro3. As you prefer

@IanButterworth IanButterworth changed the title Make tspawnat sticky Fix tspawnat on julia 1.7+ by making the task sticky Feb 1, 2022
@tro3
Copy link
Owner

tro3 commented Feb 1, 2022

@IanButterworth go for it. Thanks!

@IanButterworth IanButterworth merged commit 4473037 into tro3:master Feb 1, 2022
@IanButterworth IanButterworth deleted the ib/tspawnat_sticky branch February 1, 2022 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tasks spawned with tspawnat can migrate on 1.7
2 participants