add HTML5 validation Grunt task #291
Conversation
| @@ -43,7 +43,7 @@ <h1 class="title">Movie finder</h1> | |||
| <li class="table-view-cell table-view-divider">Recommended movies</li> | |||
| <li class="table-view-cell media"> | |||
| <a class="push-right" href="choose-theater.html" data-transition="slide-in"> | |||
| <img class="media-object pull-left" src="http://placehold.it/64x64"> | |||
| <img class="media-object pull-left" src="http://placehold.it/64x64" alt=""> | |||
There was a problem hiding this comment.
"Placeholder Image" for these placehold.it images?
There was a problem hiding this comment.
My understanding from skimming http://webaim.org/techniques/alttext/ is that alt text would be redundant in this case since we're within an <a> and there's already the movie title+description in the media-body, but I'm a novice when it comes to alt text, so I'm quite open to guidance here.
There was a problem hiding this comment.
We can allow alt failure, like in Bootstrap.
There was a problem hiding this comment.
Argh. Screen readers doesn't like images without an alt atrribute. 😟
Right alt attribute for this placeholder images is Placeholder or Placeholder image. Could you add alt?
|
👍 |
|
I say just exclude the alt check for now. |
|
@XhmikosR Good catch. Added the missing class to the iframe. Also, added non-blank alt text to the movie image links per folks' feedback. |
|
Looks good to me. 2014-02-26 20:27 GMT+01:00 Chris Rebert [email protected]:
Zlatan Vasović - ZDroid |
|
LGTM. |
add HTML5 validation Grunt task
Also includes fixes to make the HTML validate.
Fixes #282.