New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid Enum.join when working with raw binaries #17

Open

jbowtie wants to merge 1 commit into tyre:master from jbowtie:fix_1_6_exceptions

jbowtie commented Jan 28, 2018

In Elixir 1.6 two tests fail -- this is because Enum.join is converting items to UTF-8 strings.

This pull request uses iodata_to_binary and list_to_bin instead of Enum.join when calling zlib since we are working with raw binary data.


          Avoid Enum.join when working with raw binaries to avoid string conver…

710180a

…sion

altyaper commented May 11, 2018

I tested this fix and it works 👍 thanks @jbowtie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet