Interop tests #864
Merged
Interop tests #864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcoPolo
reviewed
Feb 17, 2023
| - name: Build image | ||
| run: > | ||
| cd test-plans/multidim-interop/nim/v1.0 && | ||
| make commitSha=$GITHUB_SHA image_name=nim-libp2p-head |
There was a problem hiding this comment.
Cool! is this the commit sha for the current PR?
There was a problem hiding this comment.
| "containerImageID": "nim-libp2p-head", | ||
| "transports": [ | ||
| "tcp", | ||
| "ws" |
There was a problem hiding this comment.
Nice! Lets you have a single file. Don't forget to update this when you add new capabilities :)
Menduist
commented
Feb 17, 2023
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #864 +/- ##
============================================
+ Coverage 83.62% 83.63% +0.01%
============================================
Files 86 86
Lines 15169 15169
============================================
+ Hits 12685 12687 +2
+ Misses 2484 2482 -2
|
lchenut
approved these changes
Feb 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Waiting on libp2p/test-plans#138
Will test a simple ping with every go & rust version, for every transport, muxer & encryption combo