-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refinement of Hole Punching Service #892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## unstable #892 +/- ##
============================================
+ Coverage 84.30% 84.33% +0.03%
============================================
Files 91 91
Lines 15333 15335 +2
============================================
+ Hits 12926 12933 +7
+ Misses 2407 2402 -5
|
Menduist
previously approved these changes
May 23, 2023
Menduist
reviewed
May 23, 2023
Menduist
reviewed
May 25, 2023
Menduist
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR incorporates several updates to the Hole Punching Service.
Key Changes:
The
dcutr
sync message doesn't send addresses anymore.The
dcutr
server upgrades as the incoming side instead of the client. It was necessary in order to work with go-libp2p.The
dcutr
version has been updated to exclude the version number as it is in the spec.A new condition has been added during the direct connection attempt to check if an address contains the "p2p-circuit". If it does, or if an error is encountered, the function will continue without further processing.
The initTAddress has been fixed to not accept DNS addresses. Tests were added.