-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rate Limit tests #953
Rate Limit tests #953
Conversation
Codecov Report
@@ Coverage Diff @@
## unstable #953 +/- ##
============================================
+ Coverage 83.04% 83.21% +0.17%
============================================
Files 91 91
Lines 15308 15308
============================================
+ Hits 12712 12739 +27
+ Misses 2596 2569 -27 |
e6efbba
to
f9b67f8
Compare
tests/pubsub/testgossipsub.nim
Outdated
await gossip0.peers[gossip1.switch.peerInfo.peerId].sendEncoded(newSeqWith[byte](30, 1.byte)) | ||
await sleepAsync(300.millis) | ||
|
||
check getCurrentDisconnections() == disconnections + 1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Once this actually disconnects, we should check here that we are no longer connected
Can you add a TODO?
Otherwise, LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did this and other minor improvements.
d1becbf
to
06dca09
Compare
06dca09
to
6d453c4
Compare
No description provided.