Improve the Server Actions SWC transform

[shuding]

This PR improves the Server Actions SWC transform to make it able to handle nested Action declarations (check fixture/server-actions/server/28/input.js for more details).

It is also a simplification of that transform's internal states and methods, with the removal of an extra AST pass (stmts.visit_mut_with(&mut ClosureActionReplacer { replaced_action_proxies: &self.replaced_action_proxies, })). The generated code is also smaller in some cases. So overall I'd expect the compilation and runtime performance to improve as well.

Details

With this change, we're now using self.declared_idents and self.names to track closure arguments. declared_idents keeps the identifiers declared in the current closure and above. names keeps identifiers appeared in the current closure and above. In an example of the following cursor:

let x

async function foo() {
  "use server"
  let y

  async function bar() {
    "use server"
    let z
    console.log(x, y, z)
  }

  // <- cursor
}

declared_idents would be y (x isn't in a closure), and names would be x, y, z. By manipulating these two states we're able to track closure closed-up variables recursively.

Closes NEXT-2189

[ijjk]

Stats from current PR

Default Build

General Overall increase ⚠️

	vercel/next.js canary	vercel/next.js shu/4654	Change
buildDuration	14.4s	14.3s	N/A
buildDurationCached	7.4s	6.4s	N/A
nodeModulesSize	200 MB	200 MB	⚠️ +15.9 kB
nextStartRea..uration (ms)	493ms	486ms	N/A

Client Bundles (main, webpack)

	vercel/next.js canary	vercel/next.js shu/4654	Change
193.HASH.js gzip	181 B	182 B	N/A
3f784ff6-HASH.js gzip	53.4 kB	53.4 kB	✓
433-HASH.js gzip	29 kB	29 kB	N/A
framework-HASH.js gzip	45.2 kB	45.2 kB	✓
main-app-HASH.js gzip	239 B	242 B	N/A
main-HASH.js gzip	31.8 kB	31.8 kB	N/A
webpack-HASH.js gzip	1.7 kB	1.7 kB	N/A
Overall change	98.6 kB	98.6 kB	✓

Legacy Client Bundles (polyfills)

	vercel/next.js canary	vercel/next.js shu/4654	Change
polyfills-HASH.js gzip	31 kB	31 kB	✓
Overall change	31 kB	31 kB	✓

Client Pages

	vercel/next.js canary	vercel/next.js shu/4654	Change
_app-HASH.js gzip	194 B	195 B	N/A
_error-HASH.js gzip	183 B	181 B	N/A
amp-HASH.js gzip	504 B	502 B	N/A
css-HASH.js gzip	321 B	321 B	✓
dynamic-HASH.js gzip	2.5 kB	2.5 kB	N/A
edge-ssr-HASH.js gzip	255 B	253 B	N/A
head-HASH.js gzip	350 B	349 B	N/A
hooks-HASH.js gzip	369 B	369 B	✓
image-HASH.js gzip	4.18 kB	4.18 kB	N/A
index-HASH.js gzip	255 B	256 B	N/A
link-HASH.js gzip	2.61 kB	2.61 kB	✓
routerDirect..HASH.js gzip	312 B	311 B	N/A
script-HASH.js gzip	385 B	383 B	N/A
withRouter-HASH.js gzip	307 B	308 B	N/A
1afbb74e6ecf..834.css gzip	106 B	106 B	✓
Overall change	3.4 kB	3.4 kB	✓

Client Build Manifests

	vercel/next.js canary	vercel/next.js shu/4654	Change
_buildManifest.js gzip	484 B	485 B	N/A
Overall change	0 B	0 B	✓

Rendered Page Sizes

	vercel/next.js canary	vercel/next.js shu/4654	Change
index.html gzip	529 B	528 B	N/A
link.html gzip	541 B	540 B	N/A
withRouter.html gzip	524 B	523 B	N/A
Overall change	0 B	0 B	✓

Edge SSR bundle Size

	vercel/next.js canary	vercel/next.js shu/4654	Change
edge-ssr.js gzip	94 kB	94 kB	N/A
page.js gzip	149 kB	149 kB	N/A
Overall change	0 B	0 B	✓

Middleware size

	vercel/next.js canary	vercel/next.js shu/4654	Change
middleware-b..fest.js gzip	625 B	627 B	N/A
middleware-r..fest.js gzip	151 B	151 B	✓
middleware.js gzip	37.5 kB	37.5 kB	N/A
edge-runtime..pack.js gzip	1.92 kB	1.92 kB	✓
Overall change	2.07 kB	2.07 kB	✓

Next Runtimes

	vercel/next.js canary	vercel/next.js shu/4654	Change
app-page-exp...dev.js gzip	169 kB	169 kB	✓
app-page-exp..prod.js gzip	95.6 kB	95.6 kB	✓
app-page-tur..prod.js gzip	96.3 kB	96.3 kB	✓
app-page-tur..prod.js gzip	90.9 kB	90.9 kB	✓
app-page.run...dev.js gzip	142 kB	142 kB	✓
app-page.run..prod.js gzip	90.2 kB	90.2 kB	✓
app-route-ex...dev.js gzip	24.2 kB	24.2 kB	✓
app-route-ex..prod.js gzip	16.9 kB	16.9 kB	✓
app-route-tu..prod.js gzip	16.9 kB	16.9 kB	✓
app-route-tu..prod.js gzip	16.4 kB	16.4 kB	✓
app-route.ru...dev.js gzip	23.6 kB	23.6 kB	✓
app-route.ru..prod.js gzip	16.4 kB	16.4 kB	✓
pages-api-tu..prod.js gzip	9.41 kB	9.41 kB	✓
pages-api.ru...dev.js gzip	9.68 kB	9.68 kB	✓
pages-api.ru..prod.js gzip	9.4 kB	9.4 kB	✓
pages-turbo...prod.js gzip	22 kB	22 kB	✓
pages.runtim...dev.js gzip	22.6 kB	22.6 kB	✓
pages.runtim..prod.js gzip	22 kB	22 kB	✓
server.runti..prod.js gzip	49.7 kB	49.7 kB	✓
Overall change	944 kB	944 kB	✓

Commit: 73286e9

[kevva]

I'm seeing this error after this PR (most likely):

TypeError: Cannot redefine property: $$id
    at Function.defineProperties (<anonymous>)
    at t.registerServerReference (~/project/node_modules/next/dist/compiled/next-server/app-page-experimental.runtime.dev.js:35:377754)
    at createActionProxy (webpack-internal:///(rsc)/./node_modules/next/dist/build/webpack/loaders/next-flight-loader/action-proxy.js:13:52)

My actions are defined as this:

'use server'
export const someAction = async (formData) => { … }

See #61183.