Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dispatcher.ProcessMessage crash process instead of return error #4015

Closed
RonaldinhoL opened this issue Jan 15, 2025 · 0 comments · Fixed by #4016
Closed

Dispatcher.ProcessMessage crash process instead of return error #4015

RonaldinhoL opened this issue Jan 15, 2025 · 0 comments · Fixed by #4016
Labels
Bug Something isn't working

Comments

@RonaldinhoL
Copy link
Contributor

Description

Dispatcher.ProcessMessage() throw panic instead of return error, which cause whole process was crashed

which could be many reason, for exampe: Marshal params while cause corrucrent Read/Write map err; reflect: Call using zero Value argument.

i know its not wails fault but its better to not crash the whole process

To Reproduce

illeagle params handle in Dispatcher.ProcessMessage

Expected behaviour

return error instead of crash process

Screenshots

No response

Attempted Fixes

No response

System Details

# Wails
Version | v2.9.2

# System
┌───────────────────────────────────────────────────────────────────────────┐
| OS           | Windows 10 Pro for Workstations                            |
| Version      | 2009 (Build: 19045)                                        |
| ID           | 22H2                                                       |
| Go Version   | go1.21.3                                                   |
| Platform     | windows                                                    |
| Architecture | amd64                                                      |
| CPU 1        | Intel(R) Xeon(R) CPU E5-2680 0 @ 2.70GHz                   |
| CPU 2        | Intel(R) Xeon(R) CPU E5-2680 0 @ 2.70GHz                   |
| GPU          | NVIDIA GeForce GTX 1080 Ti (NVIDIA) - Driver: 32.0.15.6094 |
| Memory       | 64GB                                                       |
└───────────────────────────────────────────────────────────────────────────┘

# Dependencies
┌────────────────────────────────────────────────────────┐
| Dependency | Package Name | Status    | Version        |
| WebView2   | N/A          | Installed | 131.0.2903.146 |
| Nodejs     | N/A          | Installed | 20.10.0        |
| npm        | N/A          | Installed | 10.2.3         |
| *upx       | N/A          | Installed | upx 4.0.2      |
| *nsis      | N/A          | Installed | v3.08          |
└─────────────── * - Optional Dependency ────────────────┘

# Diagnosis
 SUCCESS  Your system is ready for Wails development!

Additional context

No response

@RonaldinhoL RonaldinhoL added the Bug Something isn't working label Jan 15, 2025
RonaldinhoL added a commit to RonaldinhoL/wails that referenced this issue Jan 16, 2025
leaanthony pushed a commit that referenced this issue Jan 17, 2025
* recover from process message instead crash the whole app

* update changelog.mdx (#4015)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant