-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Init TUI #4046
Open
PylotLight
wants to merge
107
commits into
wailsapp:v3-alpha
Choose a base branch
from
PylotLight:feature/interactiveInit
base: v3-alpha
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+181
−5
Open
Add Init TUI #4046
Changes from all commits
Commits
Show all changes
107 commits
Select commit
Hold shift + click to select a range
3204287
Fix sponsors workflow
leaanthony ffcfa1b
fix: compute dropped file path before css handling (#3595)
FrancescoLuzzi c4c0d64
chore: update sponsors.svg (#3591)
github-actions[bot] 9efaedf
chore: update sponsors.svg (#3604)
github-actions[bot] dd6eb0f
chore: update sponsors.svg (#3618)
github-actions[bot] 482f19e
chore: update sponsors.svg (#3619)
github-actions[bot] e941f36
#3200: Use OutputFilename instead of Name (#3551)
plutov 7a40cc5
chore: update sponsors.svg (#3624)
github-actions[bot] fe9495d
chore: update sponsors.svg (#3641)
github-actions[bot] 5b091db
Fixed an error that occurred when an author name contains a string th…
taisei-86 ddf2703
chore: update sponsors.svg (#3661)
github-actions[bot] 2b35861
Fix doctor command not finding pkg-config on Solus (#3670)
ianmjones fe1f23b
If a field is exported, generate json even in the absence of tags (#3…
pbnjay 0f61873
chore: update sponsors.svg (#3679)
github-actions[bot] d36d171
Modified ZoomFactor and IsZoomControlEnabled options to be Windows-on…
levinit 9995dae
Nil pointer check for DnD (#3597)
leaanthony 3f83b42
FIX: Address Mac CGO Crash (#3590)
leaanthony 868931f
Fix typos (#3628)
deining 4b6a8e1
fix: failsafe JavaScript event emitter `notifyListeners` (#3695)
mrf345 f8c8611
Fix drag and drop missing cursor icon (#3703)
mrf345 87b1325
Update Sponsor Image (#3706)
github-actions[bot] 1a23102
Modified docs to reflect the correct password syntax for the `gon-sig…
iberflow 8e810d5
Update templates.mdx (#3567)
edai-git 475534c
V2 bugfix/windows syscall go 1.23 (#3707)
leaanthony d218384
Update Sponsor Image (#3711)
github-actions[bot] 3721d73
More syscall fixes (#3713)
leaanthony c3a7266
Update Sponsor Image (#3725)
github-actions[bot] 265d2e4
Update Sponsor Image (#3727)
github-actions[bot] f4b21a6
chore: fix DeskGap author link on credits page (#3724)
matta 5d2b430
Removed unnecessary files. Fixes #3737 (#3738)
ssahillppatell f302c80
v2.9.2
leaanthony 429e94f
Update Sponsor Image (#3767)
github-actions[bot] bd2c1ea
bugfix : fix error on building runnable .app on MacOS when 'name' and…
nickisworking a6288c4
Update Sponsor Image (#3769)
github-actions[bot] 5b85949
Update Sponsor Image (#3799)
github-actions[bot] 7a5e41f
Add Resizem to community showcase (#3813)
barats a2e32fe
Updated documentation with new wails template (#3802)
xvertile 8a5a050
fix: pass platform and arch to GenerateBindings for cross compilation…
fcying 10abe24
Update Sponsor Image (#3818)
github-actions[bot] 26ff639
Updated documentation with new wails template (#3820)
tongque0 14cc9ec
Update Sponsor Image (#3824)
github-actions[bot] 1b6ed1b
Allow set window class name via options for Windows (#3828)
APshenkin f33e627
docs: add korean translation for Introduction (#3780)
azamara a964be1
Allow to specify macos-min-version externally (#3756)
APshenkin f08f4be
Rebuild runtime js
leaanthony 5ebccf1
[Documentation]Adding notes for latest linux version and libwebkit is…
pratikmota bb4e95e
Update Sponsor Image (#3855)
github-actions[bot] f288182
Update Sponsor Image (#3858)
github-actions[bot] 758a636
Update Sponsor Image (#3863)
github-actions[bot] 157c8fd
Update to go-webview 0.1.17
leaanthony 9772523
Add wails-nextjs-tailwind-template (#3871)
kairo913 e573bf4
Update go.sum
leaanthony bdb4151
Update Sponsor Image (#3874)
github-actions[bot] 1c16342
Fixed example for macOS menu (#3847)
takuyahara d1ba26a
Fixed typo (#3846)
takuyahara 13d4b21
Update Sponsor Image (#3883)
github-actions[bot] dca2064
Update Sponsor Image (#3884)
github-actions[bot] 5df8ecc
Update PR template
leaanthony 10e3a13
chore: removed incorrect go.mod instructions (#3878)
damiensedgwick 86e3d51
Bump the go_modules group across 2 directories with 1 update (#3408)
dependabot[bot] ba38474
Bump the go_modules group across 3 directories with 1 update (#3410)
dependabot[bot] cadbccf
Update Sponsor Image (#3892)
github-actions[bot] 39c922b
Update Sponsor Image (#3899)
github-actions[bot] 63e1f3c
Fix TS definition of WindowSetSize
leaanthony e5be3c5
Update MacOS requirements
leaanthony 93b4939
chore: update svelte CLI command (#3912)
pernydev 8deb8a0
Add WailsTerm to community showcases (#3914)
rlshukhov bd57598
Update Mac AppStore Guide to support app names containing spaces (#3923)
cristianrgreco dade880
Update Sponsor Image (#3918)
github-actions[bot] 2c45ae6
Update go-webview2 to v1.0.18.
leaanthony 6345b64
Update templates.mdx (#3930)
xijaja dd4aa56
chore: fix some comments (#3932)
lvyaoting c27d2ce
Update Sponsor Image (#3938)
github-actions[bot] 896a90f
Add Minesweeper XP to Community Showcase (#3940)
AkshayKalose 42e7750
Update Sponsor Image (#3943)
github-actions[bot] e219e3b
Update Sponsor Image (#3952)
github-actions[bot] fc0aea1
Update Sponsor Image (#3956)
github-actions[bot] d730c96
docs: add Kafka King to showcase (#3964)
Bronya0 ee2156e
Added Go requirements for Mac 15+
leaanthony 461d34c
fix: prevent unnecessary redraws during window minimize/restore (#3955)
562589540 82fd9de
Fix：Adjust the first-level heading to fix the page display format (#3…
Bronya0 90be707
Update Sponsor Image (#3983)
github-actions[bot] 7566ed4
Do not attempt to export fields that cannot be json-encoded (#3975)
pbnjay 67afec3
Add grpcmd-gui to Community Showcase (#3994)
AkshayKalose caf05ad
Update Sponsor Image (#3998)
github-actions[bot] 3a4c3e7
Ensure showHiddenFiles works with directory dialog (#3904)
leaanthony d638336
Update Sponsor Image (#4002)
github-actions[bot] d9b99a9
Update Sponsor Image (#4004)
github-actions[bot] c4fdfd6
Fix miscellaneous bindings and typescript export bugs (#3978)
pbnjay 4598af4
recover from process message instead crash the whole app (#4016)
RonaldinhoL 51c7453
Update Sponsor Image (#4018)
github-actions[bot] 481c145
Update deps
leaanthony 55b90a5
Update Sponsor Image (#4022)
github-actions[bot] 00be6f2
[v2] Fix reloaddirs wails.json config (#4005)
atterpac d824318
fix dev mode logging bug (#3972)
atterpac 4a1d101
Fix invalid path for windows dialogs (#4019)
leaanthony e72a0d7
add initial version
PylotLight 3605fdf
Update dependencies. Fix `buildvcs` compile error
leaanthony fa7c6d8
Fix ErrorCancelled typo
leaanthony 536422d
Update contributors
leaanthony bedebe0
Update Sponsor Image (#4036)
github-actions[bot] 9bc3a7c
Merge branch 'v3-alpha' into feature/interactiveInit
leaanthony da56b38
Merge branch 'wailsapp:master' into feature/interactiveInit
PylotLight 86f4d49
Revert "Merge branch 'wailsapp:master' into feature/interactiveInit"
PylotLight add9ae4
update projectDetails ref and returning
PylotLight d1c8a12
remove verbose commenting
PylotLight e525fcb
update error return
PylotLight File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add input validation for critical fields.
The form lacks validation for critical fields like project name and directory.
Add validation to ensure:
Apply this diff to add validation:
huh.NewInput(). Title("Project Name"). Description("Name of project"). - Value(&options.ProjectName), + Value(&options.ProjectName). + Validate(func(s string) error { + if s == "" { + return fmt.Errorf("project name cannot be empty") + } + if !regexp.MustCompile(`^[a-zA-Z][a-zA-Z0-9_-]*$`).MatchString(s) { + return fmt.Errorf("invalid project name: must start with a letter and contain only letters, numbers, underscores, or hyphens") + } + return nil + }), huh.NewInput(). Title("Project Dir"). Description("Target directory (empty for default)"). - Value(&options.ProjectDir), + Value(&options.ProjectDir). + Validate(func(s string) error { + if s == "" { + return nil + } + if _, err := os.Stat(s); err == nil { + return fmt.Errorf("directory already exists") + } + return nil + }), huh.NewInput(). Title("Git Repo URL (optional)"). Description("Git repo to initialize (optional)"). - Value(&options.Git), + Value(&options.Git). + Validate(func(s string) error { + if s == "" { + return nil + } + if !regexp.MustCompile(`^(https?|git|ssh)://|^git@`).MatchString(s) { + return fmt.Errorf("invalid git URL format") + } + return nil + }),📝 Committable suggestion