-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add copy current url to webview context menu #1821
Conversation
WalkthroughThe pull request introduces a new feature in the WebView component of the frontend application. A method called Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
frontend/app/view/webview/webview.tsx (2)
434-439
: Consider adding error handling or user feedback.While the
copyUrlToClipboard()
method works for valid URLs,navigator.clipboard.writeText()
can fail under certain circumstances (e.g., if clipboard access is denied). Consider catching any potential errors and providing user feedback (e.g., a toast or console message) to improve reliability and user experience.async copyUrlToClipboard() { const url = this.getUrl(); if (url != null && url !== "") { - fireAndForget(() => navigator.clipboard.writeText(url)); + try { + await navigator.clipboard.writeText(url); + console.log("URL copied to clipboard."); + } catch (err) { + console.error("Could not copy URL:", err); + } } }
519-522
: Optionally hide or disable the “Copy URL” menu item when the URL is empty.If the URL is null or empty, clicking “Copy URL to Clipboard” does nothing. Consider conditionally disabling or hiding the menu item to prevent confusion.
{ label: "Copy URL to Clipboard", - click: () => this.copyUrlToClipboard(), + enabled: !!this.getUrl(), + click: () => { + if (this.getUrl()) { + this.copyUrlToClipboard(); + } + }, },
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
frontend/app/view/webview/webview.tsx
(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
- GitHub Check: Build for TestDriver.ai
No description provided.