Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wpilib] Make LinearSystemSim setState() update output #7799

Merged

Conversation

HarryXChen3
Copy link
Contributor

Establishes the invariant that the state and measurement always match up, even immediately after construction.

Fixes #7761

@HarryXChen3 HarryXChen3 requested a review from a team as a code owner February 18, 2025 06:21
@HarryXChen3 HarryXChen3 force-pushed the physics-sim-valid-initial-state branch from 3817be3 to e48658a Compare February 18, 2025 21:11
Copy link
Member

@calcmogul calcmogul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor notation issues.

@HarryXChen3 HarryXChen3 force-pushed the physics-sim-valid-initial-state branch from e48658a to 9b9cd0a Compare February 19, 2025 01:35
@calcmogul calcmogul changed the title [wpilib] Make LinearSystemSim setState update output state [wpilib] Make LinearSystemSim setState() update output Feb 19, 2025
@PeterJohnson PeterJohnson merged commit c898853 into wpilibsuite:main Feb 19, 2025
45 checks passed
@HarryXChen3 HarryXChen3 deleted the physics-sim-valid-initial-state branch February 19, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ElevatorSim output is not initially valid (until update has been called)
3 participants