Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjust: 将ege_前缀的文本输出函数的坐标参数类型由 int 改为 float #259

Merged
merged 1 commit into from
Feb 4, 2025

Conversation

yixy-only
Copy link
Collaborator

@yixy-only yixy-only commented Feb 4, 2025

Summary by CodeRabbit

  • New Features

    • Enhanced text rendering precision by allowing floating-point coordinates for text positioning.
    • Introduced new parameter pimg for several text functions to specify the target image for text output.
  • Documentation

    • Updated descriptions and examples for text display functions to clarify parameter roles and improve overall clarity regarding text output and alignment.

@yixy-only yixy-only self-assigned this Feb 4, 2025
Copy link

coderabbitai bot commented Feb 4, 2025

Walkthrough

The changes update several text output function signatures and related documentation in the Easy Graphics Engine (EGE). Function parameters for specifying coordinates have been changed from integer to float in both the header and source files. In addition, the documentation across various manuals has been revised for clarity by updating terminology (e.g., "字符串" to "文本") and refining examples and parameter explanations. These adjustments improve the precision of text positioning in graphical applications without altering the underlying functionality.

Changes

File(s) Change Summary
include/ege.h Updated signatures of ege_outtextxy and ege_xyprintf (and overloads) to accept float coordinates instead of int.
src/font.cpp Modified implementations of ege_outtextxy and ege_xyprintf functions to use float parameters for coordinates.
man/api/font/ege_drawtext.htm
man/api/font/ege_outtextxy.htm
man/api/font/ege_xyprintf.htm
Revised documentation for function signatures with float coordinates, improved parameter descriptions, and clarified examples for text drawing functions.
man/api/font/outtext.htm
man/api/font/outtextrect.htm
man/api/font/outtextxy.htm
man/api/font/settextjustify.htm
man/api/font/textheight.htm
man/api/font/textwidth.htm
man/api/font/xyprintf.htm
Updated terminology from "字符串" (string) to "文本" (text) and refined parameter descriptions across multiple text output documentation files.
man/api/font/getfont.htm
man/api/font/setfont.htm
Modified descriptions to clarify the role of the new pimg parameter for specifying target images in font functions.

Sequence Diagram(s)

sequenceDiagram
    participant App as Application
    participant EGE as Easy Graphics Engine
    participant Render as Renderer

    App->>EGE: Call text output function (e.g., ege_outtextxy/xyprintf) with float coordinates
    EGE->>Render: Forward request with precise positioning
    Render-->>EGE: Return rendered output
    EGE-->>App: Display text on screen
Loading

Possibly related PRs

  • chore: 消除部分编译器警告 #258: Addresses similar modifications for the ege_xyprintf function with updates focused on string handling improvements, directly related through shared code changes.

Poem

I'm a rabbit in a code-filled glen,
Hoping through each revision again.
Float coordinates now guide my hop,
Text appears with an elegant pop!
ASCII carrots and code delight,
Happy changes make my world so bright!
🥕🐇 Enjoy the precise digital light!

Tip

🌐 Web search-backed reviews and chat
  • We have enabled web search-based reviews and chat for all users. This feature allows CodeRabbit to access the latest documentation and information on the web.
  • You can disable this feature by setting web_search: false in the knowledge_base settings.
  • Please share any feedback in the Discord discussion.
✨ Finishing Touches
  • 📝 Generate Docstrings (Beta)

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🔭 Outside diff range comments (2)
man/api/font/xyprintf.htm (1)

16-17: Function signatures need to be updated to use float parameters

The PR title indicates changing coordinate parameters from int to float, but the function signatures still show int parameters for x and y coordinates.

Update the parameter types in the function signatures:

-    <font color=#0000FF>int </font>x,
-    <font color=#0000FF>int </font>y,
+    <font color=#0000FF>float </font>x,
+    <font color=#0000FF>float </font>y,

And similarly for the second function signature.

Also applies to: 22-23

man/api/font/outtextxy.htm (1)

16-17: Critical: Update coordinate parameter types to float.

The function signatures still use int for x and y parameters. These should be updated to float to maintain consistency with the PR objective and other function signatures.

Apply this change to all four function signatures:

-    int x,
-    int y,
+    float x,
+    float y,

Also applies to: 23-24, 30-31, 37-38

🧹 Nitpick comments (1)
man/api/font/ege_outtextxy.htm (1)

63-63: Consider updating examples to demonstrate float precision.

While the changes are correct, the examples could better demonstrate the benefit of float parameters by using decimal values.

Consider updating the examples like this:

-ege_outtextxy(10, 20, s);
+ege_outtextxy(10.5, 20.3, s);
-ege_outtextxy(10, 40, c);
+ege_outtextxy(10.7, 40.2, c);
-ege_outtextxy(10, 60, s);
+ege_outtextxy(10.4, 60.8, s);
-ege_xyprintf(10, 60, "value:%d", 1024);
+ege_xyprintf(10.4, 60.8, "value:%d", 1024);

Also applies to: 67-67, 72-72, 75-75

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d1aebb1 and 27a6485.

📒 Files selected for processing (12)
  • include/ege.h (1 hunks)
  • man/api/font/ege_drawtext.htm (2 hunks)
  • man/api/font/ege_outtextxy.htm (2 hunks)
  • man/api/font/ege_xyprintf.htm (1 hunks)
  • man/api/font/outtext.htm (1 hunks)
  • man/api/font/outtextrect.htm (2 hunks)
  • man/api/font/outtextxy.htm (3 hunks)
  • man/api/font/settextjustify.htm (2 hunks)
  • man/api/font/textheight.htm (2 hunks)
  • man/api/font/textwidth.htm (2 hunks)
  • man/api/font/xyprintf.htm (2 hunks)
  • src/font.cpp (2 hunks)
✅ Files skipped from review due to trivial changes (2)
  • man/api/font/outtext.htm
  • man/api/font/outtextrect.htm
🧰 Additional context used
🪛 Cppcheck (2.10-2)
src/font.cpp

[error] 315-315: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 316-316: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 317-317: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 318-318: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 319-319: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 320-320: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 321-321: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 322-322: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 323-323: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 324-324: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 325-325: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 326-326: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 327-327: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 328-328: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 329-329: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 330-330: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 331-331: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 332-332: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 333-333: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 334-334: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 335-335: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 336-336: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 337-337: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 357-357: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)

⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: TESTING
🔇 Additional comments (14)
man/api/font/textwidth.htm (1)

12-12: Documentation improvements look good!

The changes enhance clarity by:

  • Explaining that width calculation depends on font settings
  • Using consistent terminology
  • Improving parameter descriptions

Also applies to: 21-21, 25-25

man/api/font/textheight.htm (1)

12-12: Documentation improvements look good!

The changes maintain consistency with textwidth.htm and enhance clarity by:

  • Explaining that height calculation depends on font settings
  • Using consistent terminology
  • Improving parameter descriptions

Also applies to: 21-21, 25-25

man/api/font/xyprintf.htm (1)

12-12: Documentation improvements look good!

The changes enhance clarity by:

  • Improving function description
  • Clarifying coordinate parameter descriptions
  • Using consistent terminology

Also applies to: 31-31, 34-34, 40-40

man/api/font/ege_drawtext.htm (1)

12-12: Changes look good!

The updates successfully:

  • Change coordinate parameters from int to float for better precision
  • Improve function description to clarify color setting options
  • Enhance parameter descriptions
  • Maintain consistency with other documentation changes

Also applies to: 17-18, 23-24, 34-34, 37-37

man/api/font/ege_xyprintf.htm (1)

12-12: LGTM! Parameter type changes and description updates look good.

The changes correctly implement the PR objective of changing coordinate parameters from int to float. The updated description also improves clarity by explicitly mentioning ARGB color control.

Also applies to: 16-17

man/api/font/settextjustify.htm (1)

12-12: LGTM! Terminology updates and parameter descriptions are clear.

The changes maintain consistency with other documentation files by using "文本" terminology and add helpful clarification for the pimg parameter.

Also applies to: 34-35

man/api/font/ege_outtextxy.htm (1)

16-17: LGTM! Parameter type changes are correctly implemented.

The function signatures have been properly updated to use float for coordinate parameters, aligning with the PR objective.

Also applies to: 23-24, 30-31, 37-38

src/font.cpp (6)

315-318: LGTM: Function signature change is correctly implemented.

The ege_outtextxy function for const char* text has been updated to use float parameters for x and y coordinates, and the implementation correctly passes these parameters to ege_drawtext.

🧰 Tools
🪛 Cppcheck (2.10-2)

[error] 315-315: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 316-316: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 317-317: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 318-318: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


320-323: LGTM: Function signature change is correctly implemented.

The ege_outtextxy function for const wchar_t* text has been updated to use float parameters for x and y coordinates, and the implementation correctly passes these parameters to ege_drawtext.

🧰 Tools
🪛 Cppcheck (2.10-2)

[error] 320-320: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 321-321: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 322-322: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 323-323: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


325-329: LGTM: Function signature change is correctly implemented.

The ege_outtextxy function for char has been updated to use float parameters for x and y coordinates, and the implementation correctly handles the conversion to string and passes to ege_drawtext.

🧰 Tools
🪛 Cppcheck (2.10-2)

[error] 325-325: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 326-326: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 327-327: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 328-328: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 329-329: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


331-335: LGTM: Function signature change is correctly implemented.

The ege_outtextxy function for wchar_t has been updated to use float parameters for x and y coordinates, and the implementation correctly handles the conversion to string and passes to ege_drawtext.

🧰 Tools
🪛 Cppcheck (2.10-2)

[error] 331-331: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 332-332: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 333-333: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 334-334: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 335-335: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


337-355: LGTM: Function signature change is correctly implemented with buffer safety.

The ege_xyprintf function for const char* format has been updated to use float parameters for x and y coordinates. The implementation includes a safe buffer handling approach by:

  1. Using the middle of the buffer to avoid overlap with ege_drawtext
  2. Correctly calculating buffer size for both MSVC and other compilers
🧰 Tools
🪛 Cppcheck (2.10-2)

[error] 337-337: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 338-338: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 339-339: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 340-340: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 341-341: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 342-342: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 343-343: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 344-344: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 345-345: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 346-346: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 347-347: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 348-348: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 349-349: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 350-350: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 351-351: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 352-352: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 353-353: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 354-354: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 355-355: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


357-373: LGTM: Function signature change is correctly implemented.

The ege_xyprintf function for const wchar_t* format has been updated to use float parameters for x and y coordinates, and the implementation correctly handles wide character formatting.

🧰 Tools
🪛 Cppcheck (2.10-2)

[error] 357-357: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 358-358: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 359-359: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 360-360: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 361-361: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 362-362: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 363-363: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 364-364: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 365-365: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 366-366: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 367-367: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 368-368: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 369-369: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 370-370: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 371-371: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 372-372: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 373-373: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)

include/ege.h (1)

1265-1270: LGTM: Function declarations are correctly updated.

The function declarations have been correctly updated to use float parameters for x and y coordinates:

  1. ege_outtextxy for all text types (char*, wchar_t*, char, wchar_t)
  2. ege_xyprintf for both format types (char*, wchar_t*)

The changes are consistent with the implementations in src/font.cpp.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (4)
man/api/font/getfont.htm (1)

12-12: Documentation changes look good!

The updates improve clarity by explicitly stating the function's context (image/window) and adding the pimg parameter consistently with other functions.

Consider adding a cross-reference to related functions like setfont to help users understand the relationship between these functions.

Also applies to: 23-24

man/api/font/ege_xyprintf.htm (1)

12-12: Documentation updates align well with the coordinate type changes!

The changes effectively:

  • Update x,y parameter types to float
  • Clarify text positioning behavior
  • Add a practical example with float coordinates

Consider adding more examples demonstrating:

  • Text alignment effects
  • Text rotation effects
  • Different coordinate precision cases

Also applies to: 16-17, 22-23, 31-31, 34-34, 39-40, 48-48

man/api/font/ege_drawtext.htm (1)

12-12: Documentation changes are consistent and clear!

The updates successfully:

  • Change coordinate types to float
  • Add pimg parameter with clear explanation
  • Improve function and parameter descriptions

Consider enhancing the example section to demonstrate:

  • Using the pimg parameter
  • Complex text formatting
  • Different coordinate precision scenarios

Also applies to: 17-19, 23-25, 34-34, 37-37, 39-40, 47-47

man/api/font/setfont.htm (1)

12-12: Documentation updates enhance clarity and consistency!

The changes effectively:

  • Clarify the function's context (image/window)
  • Add pimg parameter description consistently with other functions
  • Maintain relationship with color setting functions

Consider updating the example section to demonstrate:

  • Using the pimg parameter
  • Setting fonts for different targets (window vs. image)

Also applies to: 126-128

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 27a6485 and 11c7caa.

📒 Files selected for processing (14)
  • include/ege.h (1 hunks)
  • man/api/font/ege_drawtext.htm (2 hunks)
  • man/api/font/ege_outtextxy.htm (1 hunks)
  • man/api/font/ege_xyprintf.htm (1 hunks)
  • man/api/font/getfont.htm (2 hunks)
  • man/api/font/outtext.htm (1 hunks)
  • man/api/font/outtextrect.htm (2 hunks)
  • man/api/font/outtextxy.htm (2 hunks)
  • man/api/font/setfont.htm (2 hunks)
  • man/api/font/settextjustify.htm (2 hunks)
  • man/api/font/textheight.htm (2 hunks)
  • man/api/font/textwidth.htm (2 hunks)
  • man/api/font/xyprintf.htm (2 hunks)
  • src/font.cpp (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (9)
  • man/api/font/outtextrect.htm
  • man/api/font/outtextxy.htm
  • man/api/font/outtext.htm
  • man/api/font/textwidth.htm
  • man/api/font/textheight.htm
  • man/api/font/xyprintf.htm
  • include/ege.h
  • man/api/font/ege_outtextxy.htm
  • man/api/font/settextjustify.htm
🧰 Additional context used
🪛 Cppcheck (2.10-2)
src/font.cpp

[error] 315-315: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 316-316: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 317-317: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 318-318: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 319-319: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 320-320: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 321-321: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 322-322: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 323-323: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 324-324: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 325-325: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 326-326: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 327-327: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 328-328: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 329-329: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 330-330: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 331-331: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 332-332: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 333-333: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 334-334: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 335-335: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 336-336: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 337-337: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 357-357: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)

🔇 Additional comments (2)
src/font.cpp (2)

315-335: LGTM! Parameter type changes look good.

The coordinate parameter types have been correctly updated from int to float across all ege_outtextxy overloads. The implementation properly forwards to ege_drawtext which already accepts float parameters.

🧰 Tools
🪛 Cppcheck (2.10-2)

[error] 315-315: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 316-316: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 317-317: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 318-318: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 319-319: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 320-320: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 321-321: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 322-322: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 323-323: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 324-324: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 325-325: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 326-326: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 327-327: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 328-328: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 329-329: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 330-330: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 331-331: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 332-332: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 333-333: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 334-334: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 335-335: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


337-373: LGTM! Parameter type changes look good.

The coordinate parameter types have been correctly updated from int to float across both ege_xyprintf overloads. The implementation maintains proper buffer management and correctly forwards to ege_outtextxy.

🧰 Tools
🪛 Cppcheck (2.10-2)

[error] 337-337: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 338-338: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 339-339: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 340-340: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 341-341: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 342-342: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 343-343: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 344-344: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 345-345: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 346-346: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 347-347: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 348-348: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 349-349: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 350-350: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 351-351: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 352-352: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 353-353: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 354-354: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 355-355: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 356-356: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 357-357: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 358-358: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 359-359: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 360-360: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 361-361: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 362-362: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 363-363: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 364-364: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 365-365: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 366-366: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 367-367: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 368-368: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 369-369: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 370-370: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 371-371: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 372-372: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)


[error] 373-373: Signed integer overflow for expression '0xFF<<24'.

(integerOverflow)

@yixy-only yixy-only merged commit b7abf8f into wysaid:master Feb 4, 2025
2 checks passed
@yixy-only yixy-only deleted the adjust_ege_text branch February 4, 2025 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant