fix: parsing large labels over int32.MaxValue caused a loop in the parser #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rser This was only broken by maximum number of errors, but that is a week constraint and reported wrong number of issues. **This fix doesn't introduce support for long labels.**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toolkit currently reads entity labels as integers. This is for performance reasons as keeping all entity labels as long would increase amount of memory used by the applications considerably. Also,
Int32.MaxValueprovides enough space even for very large models. In the future, we may introduce internal parser time mapping to handle these special files.In the current implementation, exception in label conversion caused a loop. This was only broken by maximum number of errors, but that is a week constraint and reported wrong number of issues. This fix doesn't introduce support for long labels.