Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multi hosts #163

Merged
merged 7 commits into from
Jun 22, 2022
Merged

Add multi hosts #163

merged 7 commits into from
Jun 22, 2022

Conversation

Gerych1984
Copy link
Contributor

@Gerych1984 Gerych1984 commented Jun 7, 2022 •
edited
Loading

Q A
Is bugfix? ❌
New feature? ✔️
Breaks BC? ❌
Fixed issues #159
  1. Allow several hosts in Route::host method
  2. Add method Route::isMultiHost

vjik
vjik reviewed Jun 8, 2022
View reviewed changes
samdark
samdark reviewed Jun 20, 2022
View reviewed changes
@samdark
Copy link
Member

samdark commented Jun 20, 2022

Looks good. Need a line for CHANGELOG.

@samdark samdark added the type:enhancement Enhancement label Jun 20, 2022
@Gerych1984
Copy link
Contributor Author

Looks good. Need a line for CHANGELOG.

Done

rustamwin
rustamwin reviewed Jun 22, 2022
View reviewed changes
@samdark samdark merged commit 823bafa into yiisoft:master Jun 22, 2022
@samdark
Copy link
Member

samdark commented Jun 22, 2022

Thanks!

@rustamwin rustamwin mentioned this pull request Jun 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vjik vjik vjik left review comments

@rustamwin rustamwin rustamwin left review comments

@samdark samdark samdark approved these changes

Assignees
No one assigned
Labels
type:enhancement Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gerych1984 @samdark @vjik @rustamwin