Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rector [batch] #173

Merged
merged 14 commits into from
Nov 11, 2022
Merged

Add rector [batch] #173

merged 14 commits into from
Nov 11, 2022

Conversation

xepozz
Copy link
Member

@xepozz xepozz commented Sep 27, 2022

Added rector/rector to CI and composer.json. Mass creation refers to yiisoft/yii-dev-tool#232

@rustamwin rustamwin marked this pull request as ready for review November 9, 2022 06:58
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Base: 98.11% // Head: 97.87% // Decreases project coverage by -0.23% ⚠️

Coverage data is based on head (0733576) compared to base (d543cd8).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #173      +/-   ##
============================================
- Coverage     98.11%   97.87%   -0.24%     
+ Complexity      168      144      -24     
============================================
  Files            10       10              
  Lines           425      377      -48     
============================================
- Hits            417      369      -48     
  Misses            8        8              
Impacted Files Coverage Δ
src/CurrentRoute.php 100.00% <ø> (ø)
src/Middleware/Router.php 100.00% <ø> (ø)
src/UrlGeneratorInterface.php 0.00% <ø> (ø)
src/Group.php 100.00% <100.00%> (ø)
src/MatchingResult.php 100.00% <100.00%> (ø)
src/Route.php 100.00% <100.00%> (ø)
src/RouteCollection.php 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rustamwin rustamwin requested a review from a team November 9, 2022 07:13
@rustamwin rustamwin added the status:code review The pull request needs review. label Nov 9, 2022
@rustamwin rustamwin added this to the 2.0.0 milestone Nov 9, 2022
@@ -1,8 +1,9 @@
# Yii Router Change Log

## 1.2.1 under development
## 2.0.0 under development
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems, this PR don't contain major changes...

Co-authored-by: Sergei Predvoditelev <[email protected]>
@vjik vjik merged commit 171db05 into master Nov 11, 2022
@vjik vjik deleted the add-rector branch November 11, 2022 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants