Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update yiisoft/middleware-dispatcher version to 5.0 #185

Merged
merged 2 commits into from
Jan 9, 2023

Conversation

rustamwin
Copy link
Member

Q A
Is bugfix?
New feature? ✔️/❌
Breaks BC? ✔️/❌
Fixed issues comma-separated list of tickets # fixed by the PR, if any

@what-the-diff
Copy link

what-the-diff bot commented Jan 9, 2023

  • Removed WrapperFactory from MiddlewareDispatcher
  • Updated middleware-dispatcher version to 5.0 in composer.json file
  • Changed the way of creating RouterMiddleware and RouteCollectionTest::getDispatcher() methods

@codecov
Copy link

codecov bot commented Jan 9, 2023

Codecov Report

Base: 95.33% // Head: 95.56% // Increases project coverage by +0.22% 🎉

Coverage data is based on head (153b878) compared to base (75b086a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #185      +/-   ##
============================================
+ Coverage     95.33%   95.56%   +0.22%     
  Complexity      140      140              
============================================
  Files            10       10              
  Lines           429      428       -1     
============================================
  Hits            409      409              
+ Misses           20       19       -1     
Impacted Files Coverage Δ
src/UrlGeneratorInterface.php 0.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rustamwin rustamwin requested a review from a team January 9, 2023 15:25
@rustamwin rustamwin added the status:code review The pull request needs review. label Jan 9, 2023
@vjik vjik merged commit e4aed14 into master Jan 9, 2023
@vjik vjik deleted the update-middleware-dispatcher branch January 9, 2023 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status:code review The pull request needs review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants