Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change all outPutLog to slog.Error or slog.Info #628

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Conversation

yorukot
Copy link
Owner

@yorukot yorukot commented Feb 19, 2025

No description provided.

@yorukot yorukot marked this pull request as ready for review February 19, 2025 14:00
Copy link

netlify bot commented Feb 19, 2025

Deploy Preview for superfile canceled.

Name Link
🔨 Latest commit 6b8ee0c
🔍 Latest deploy log https://app.netlify.com/sites/superfile/deploys/67b747f299958a000854df38

@lazysegtree
Copy link
Collaborator

Thanks for this @yorukot . Although lets wait to merge this after the sidebar search PR. As that PR also touches most of the the files touched in this PR.

@yorukot
Copy link
Owner Author

yorukot commented Feb 20, 2025

Yes I think so too!

@lazysegtree
Copy link
Collaborator

Rebased the branch

Copy link
Collaborator

@lazysegtree lazysegtree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We should merge it now.

@yorukot yorukot merged commit 6f88164 into main Feb 21, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants