Problem: bind can fail after open_socket succeeds on Windows without AF_UNIX #4422
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4386
Following discussion in #4386, this is a more specific check requested by @bluca rather than a catch-all. Only failures up to the initial bind are considered for fallback to tcpip.
I can't reproduce the error, so I don't know exactly what errno to check for to make the condition even more specific.
Also adds the missing check of the returned rc from make_fd_pair, which should have raised the actual error instead of the cryptic
src\epoll.cpp:100
reported in zeromq/pyzmq#1505