Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: bind can fail after open_socket succeeds on Windows without AF_UNIX #4422

Merged
merged 2 commits into from
Sep 8, 2022

Conversation

minrk
Copy link
Member

@minrk minrk commented Sep 8, 2022

closes #4386

Following discussion in #4386, this is a more specific check requested by @bluca rather than a catch-all. Only failures up to the initial bind are considered for fallback to tcpip.

I can't reproduce the error, so I don't know exactly what errno to check for to make the condition even more specific.

Also adds the missing check of the returned rc from make_fd_pair, which should have raised the actual error instead of the cryptic src\epoll.cpp:100 reported in zeromq/pyzmq#1505

since it can fail, e.g. Windows + AF_UNIX
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants