Translate struct/union/array initializers and improve zero values #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sno2
force-pushed
the
struct-union-array-init
branch
from
785a637 to
d1de6a6
Compare
Vexu
reviewed
Feb 11, 2025
sno2
force-pushed
the
struct-union-array-init
branch
from
d1de6a6 to
2645469
Compare
|
Seems like the build is failing from a |
|
There is a PR open in the arocc repo to fix this: Vexu/arocc#843 |
sno2
changed the title
Vexu
reviewed
Feb 11, 2025
Co-Authored-By: Veikka Tuominen <[email protected]>
|
I'll also include the arocc update in this if you don't mind. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test/cases/translate/struct_in_struct_init_to_zero.ctest had an unusedPTRmacro, so I moved it to a separate test to stop it from blocking a union initializer test.Struct initialization with named and anonymous values is affected by an upstream bug in arocc: Vexu/arocc#842. This is the only thing stopping
test/cases/translate/struct_initializer_-_simple.cfrom passing.