abiAndDynamicLinkerFromFile: return an error when the file is not actually dynamic #19928
+67
−51
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partly addresses #14577
One more thing needs to be solved -- on my glibc system with a statically linked
env
, the default ABI is set to musl:Now, passing -DZIG_TARGET_TRIPLE explicitly at compile time should resolve this (for local builds ofc, official zig releases would still have this issue), but then linking with shared LLVM breaks as the CMake code assumes that if ZIG_TARGET_TRIPLE is explicitly specified, we must be cross compiling and linking static LLVM libs for simplicity.. Any hints wrt solving this in a sane manner?