resinator: Sync with upstream

[squeek502]

The end result of this PR is somewhat boring--it's just some bug fixes, mostly for obscure edge cases--but the journey was not straightforward.

This PR has had 3 distinct versions:

The tightly integrated version

The original plan was to implement what's detailed here: make resinator compile directly to COFF object files, and then send those to the linker instead of .res files.

However, the plan (as I understand it) is now for resinator to become a build system thing rather than part of the compiler, following the lead of translate-c (relevant issue), so tight integration with the compiler would be wasted effort.

The drop-in windres version

The master version of resinator has support for outputting COFF object files, and one other potential use case that opens up is providing a windres-compatible CLI interface (since windres can also output COFF object files).

So, the second plan was to add a zig windres command (see #9564 (comment)). This could be useful, because CMake can use windres when cross-compiling, so being able to do something like RC="zig windres" CC="zig cc --target=x86_64-windows-gnu" cmake ... would be quite nice.

From my testing, however, CMake only recognizes the RC compiler as windres if "windres" is in the 'main' program name (i.e. zigwindres would work and CMake would give it windres-style arguments, but zig windres still gets rc.exe-style arguments). So, having a zig windres command wouldn't actually help that much to enable this use case without a wrapper script.

The bug fix version

So, ultimately, the windres subcommand and all COFF object file stuff was excluded from this update for the sake of simplicity. Instead, it's mostly just bug fixes.

However, the CMake cross-compiling use case is still addressed, because it turns out the only thing really blocking it before was CMake giving the RC compiler absolute paths, which resinator tried to interpret as flags, e.g. /home/foo/bar.rc would be interpreted as the flag /h which prints the help screen and exits. Note that this behavior is 'correct' in terms of rc.exe, since it is Windows-only and uses / as an option prefix.

To support the CMake use-case, resinator's CLI parser has been updated to infer when an argument might actually be an absolute filepath (see the looksLikeFilepath function in resinator/cli.zig).

So, RC="zig rc" will now work in combination with zig cc and CMake. Here's an example of cross-compiling a simple Windows GUI CMake project:

$ RC="zig rc" CC="zig cc --target=x86_64-windows-gnu" cmake .. -DCMAKE_SYSTEM_NAME=Windows -G Ninja
$ ninja dialogtest
[1/5] Building RC object dialog/CMakeFiles/dialogtest.dir/dialog.rc.res
<cli>: note: this argument was inferred to be a filepath, so argument parsing was terminated
 ... /home/ryan/Programming/misc/win32-resource-tests/dialog/dialog.rc
     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

[5/5] Linking C executable dialog/dialogtest.exe

Running the result with wine (the dialog, the button, and the label come from the .rc file):

Re-closes #9564 (cc @alexrp)

[andrewrk]

Thanks for the nice writeup as well as the sync.