Unify and fix the checks for zirDiv*() #22776
Open
+242
−255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close ziglang#22749, close ziglang#22748, complete the "if the RHS is one, return the LHS directly" TODOs, fix a crash on `intvec{undefined} / intvec{-1}` and fix some compile errors: * @divExact should not cause a compile error for integer undefined lhs and runtime-known rhs, because execution is completely legal when rhs == 1, and the policy on other operations has so far been to only error if illegal behavior is guaranteed to happen. * Compile errors for float division by zero make little sense given that they are perfectly well-defined IEEE operations. The comments suggest that this was possibly made illegal intentionally, maybe in service of explicitness / "only way to do things" (so you have to use math.inf / math.nan), but that would contradict the general principle that comptime operations behave like runtime, and would add annoying special-cases to some comptime calculations. The @...Div() intrins allowed only *floating-point zero divided by zero*, which should be, if anything, *more* ill-defined any other division by zero, and probably shouldn't result in zero.
tau-dev
changed the title
comptime_floats shall not be inf or nan.
They don't even reproduce on the build machine.
|
I also have a patch to implement the rest of #21205 (comment), should I add that here or make a separate PR? |
|
I'm in the process of a big overhaul to arithmetic handling which will supersede this PR and probably a few others; sorry. |
How can contributors avoid this kind of situation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #22749, close #22748, close #21198, complete the "if the RHS is one, return the LHS directly" TODOs, fix a crash on
intvec{undefined} / intvec{-1}and fix some compile errors:comptime_float#21205. But in general, it that behavior would contradict the principle that comptime operations behave like runtime, and would add annoying special-cases to some comptime calculations. The @...Div() intrins allowed only floating-point zero divided by zero, which should be, if anything, more ill-defined than any other division by zero, and probably shouldn't result in zero.