Change WMISampler class to create a single thread, owned by the object #3987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
that always does the WMI queries. Only call CoInitialize once. Attempt to not trigger apparent bug in win2016 which causes a memory leak.
|
Not a full review, but as a general design comment I'd rather not inherit from Thread, and keep the class hierarchy as-is. |
ofek
requested changes
Jun 26, 2019
| self._current_sample = self._query() | ||
|
|
||
| self._previous_sample = self._current_sample | ||
| self._current_sample = self._query() |
There was a problem hiding this comment.
Unless I'm being daft, self._query is never defined
There was a problem hiding this comment.
I think it is defined here on line 433
There was a problem hiding this comment.
Ah ty, I was misreading the deletion on line 145
derekwbrown
force-pushed
the
db/wmi_on_own_thread
branch
from
50cd0f6 to
82bfb7a
Compare
Fix import order
derekwbrown
force-pushed
the
db/wmi_on_own_thread
branch
from
82bfb7a to
91114ba
Compare
ofek
approved these changes
Jun 28, 2019
ofek
changed the title
ofek
pushed a commit
that referenced
this pull request
Jun 29, 2019
…t, (#3987) * Change WMISampler class to create a single thread, owned by the object, that always does the WMI queries. Only call CoInitialize once. Attempt to not trigger apparent bug in win2016 which causes a memory leak. * Fix improper initializaiton of `_sampling` Fix import order
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Changes the implementation behavior or the WMISampler class, used to do WMI requests.
Old version created a new thread for each request, which in turn required CoInitialize() on that
new thread. This behavior apparently triggers a memory leak in win2016.
New implementation creates a single thread per WMISampler object instance. That thread just waits to be signaled, and when it does, it runs the WMI query. By doing this we
Motivation
Memory leak detected in agent core process
Review checklist (to be filled by reviewers)
changelog/andintegration/labels attached