Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use timeout duration again #6575

Closed
wants to merge 1 commit into from
Closed

Use timeout duration again #6575

wants to merge 1 commit into from

Conversation

hithwen
Copy link
Contributor

@hithwen hithwen commented May 5, 2020

Timeout usage was removed in #3987

@hithwen hithwen requested review from a team as code owners May 5, 2020 09:33
@codecov
Copy link

codecov bot commented May 5, 2020 •
edited
Loading

Codecov Report

Merging #6575 into master will increase coverage by 3.45%.
The diff coverage is n/a.

Impacted Files Coverage Δ
ceph/tests/conftest.py
etcd/datadog_checks/etcd/etcd.py
...kube_controller_manager/kube_controller_manager.py
datadog_checks_dev/tests/test_docker.py
kubelet/tests/test_common.py
marathon/datadog_checks/marathon/__about__.py
http_check/tests/test_integration.py
ssh_check/datadog_checks/ssh_check/ssh_check.py
kubelet/tests/test_cadvisor.py
ssh_check/datadog_checks/ssh_check/__init__.py
... and 631 more

AlexandreYang
AlexandreYang requested changes May 5, 2020
View reviewed changes
datadog_checks_base/datadog_checks/base/checks/win/wmi/sampler.py
@@ -182,6 +185,8 @@ def _query_sample_loop(self):
raise

while True:
if time.time() > time_started + self._timeout_duration:
raise TimeoutException()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a unit test for timeout case ?

derekwbrown
derekwbrown suggested changes May 5, 2020
View reviewed changes
Copy link
Contributor

@derekwbrown derekwbrown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to test this code.

@hithwen
Copy link
Contributor Author

hithwen commented May 7, 2020

Sorted in #6576

@hithwen hithwen closed this May 7, 2020
@ofek ofek deleted the julia/reintroduce-timeout-in-wmi branch May 7, 2020 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekwbrown derekwbrown derekwbrown requested changes

@AlexandreYang AlexandreYang AlexandreYang requested changes

Assignees
No one assigned
Labels
integration/datadog_checks_base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hithwen @derekwbrown @AlexandreYang