Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow libcdb search offline database #2259
Allow libcdb search offline database #2259
Changes from 20 commits
ce348a4
28e5c73
541398c
20b6cd6
1236b82
6f80685
966ce41
4c705a1
1fad910
d9d1706
1507d79
efe7908
2edbf33
6181a9a
86ca7e3
a0d4ae4
f99c44a
2d71793
4064f42
d3fb137
ec3fc6d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Attempting to unstrip the libc should be enabled by default, so this can be cleaned up the other way around to only keep the
--no-unstrip
but default toTrue
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okey, but I believe it would be better to set the default value of
--no-unstrip
toFalse
. This way, I can passnot args.no_unstrip
as the value forunstrip
.In the following code, by default,
unstrip
isTrue
. If we use the--no-unstrip
, theunstrip
parameter will becomeFalse
.