CallSiteValue::get_called_fn_value: return None on indirect calls #572
+119
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
airwoodix
force-pushed
the
issue-571
branch
8 times, most recently
from
181123f to
a4229d5
Compare
TheDan64
reviewed
Feb 22, 2025
src/values/call_site_value.rs
Outdated
| #[llvm_versions(8..)] | ||
| #[inline] | ||
| fn get_called_fn_value_check_type_consistency(&self, fn_value: Option<FunctionValue<'ctx>>) -> Option<FunctionValue<'ctx>> { | ||
| fn_value.filter(|fn_value| fn_value.get_type() == self.get_called_fn_type()) |
There was a problem hiding this comment.
Please use cargo fmt on your changes... it appears to be mixing in tabs and looks off
There was a problem hiding this comment.
Thanks for the feedback! I fixed formatting issues related to the changes in this PR. Other changes applied by rustfmt are in #575.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #571.
CallSiteValue::get_called_fn_valuenow matches the behavior ofCallBase::getCalledFunctionand returnsNonewhen the underlying instruction is an indirect call or a type inconsistency is detected (the latter only for LLVM >= 8).CallSiteValue::get_called_fn_typecorresponds toCallBase::getFunctionTypeand returns the type of the function called by the underlying call/invoke instruction. This is always well defined, whether the call is indirect or not. This new function only exists for LLVM >=8 because it depends onLLVMGetCalledFunctionType.Related Issue
#571
How This Has Been Tested
Non-regression on #571 is tested by a dedicated test which uses a simplified version of the issue's reproduction code. For simplicity, this test is restricted to LLVM >= 15 (the test's IR snippet uses opaque pointers).
Doctests of
CallSiteValue::get_called_fn_valueand the newCallSiteValue::get_called_fn_typecover the usual-case, happy paths.Breaking Changes
CallSiteValue::get_called_fn_valuenow returns anOption<FunctionValue>instead of aFunctionValueto model the fact that it may not be possible to retrieve the underlying function value (when the call is indirect).Discussion
FunctionValue::newdiffers from most other type constructors (e.g.FunctionType::new) since it checks for the safety requirements and returnsNoneif they are not met:unsafe?unsafe?Checklist