Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: run rustfmt check, fix typos check #575

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

airwoodix
Copy link
Contributor

@airwoodix airwoodix commented Feb 23, 2025

Description

  • Apply rustfmt globally.
  • Fix typos (partially overlaps with docs: fix warnings and typos #574)
  • Add a formatting check to the CI pipeline:
    • The job was missing a repository checkout, which lead to typos running against no files.

The latter is a suggestion to improve the direct feedback when opening PRs. Would you also consider adding a minimal pre-commit configuration?

@airwoodix airwoodix marked this pull request as ready for review February 23, 2025 09:58
@airwoodix airwoodix marked this pull request as draft February 23, 2025 10:30
@airwoodix airwoodix marked this pull request as ready for review February 23, 2025 10:38
@airwoodix airwoodix changed the title workflows: run rustfmt check workflows: run rustfmt check, fix typos check Feb 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant