-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converts the list assessment to use the HTML parser #21726
Conversation
Pull Request Test Coverage Report for Build 63d0eb491ae49929262380332403fe2dde48f7e0Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
In Shopify, I tested this PR together with this one https://github.com/Yoast/shopify-seo/pull/2017, since it's not merged yet. Otherwise Lists assessment is not available on product pages. |
CR and acceptance test: Everything works well, I tested both on Woo products and Shopify products. I pushed some additional commits to make sure that the assessment only counts non-empty lists. Further discussion on this approach can be seen in this Slack thread. |
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/lingo-other-tasks/issues/172