-
Notifications
You must be signed in to change notification settings - Fork 907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Converts the sentence beginnings assessment to use the HTML parser #21974
base: trunk
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 59dc44dfe3bfb7a70de4304bb748af2addb5667aDetails
💛 - Coveralls |
// This test currently fails because "no." is regarded an abbreviation. | ||
xit( "returns an object with sentence beginnings and counts for two sentences in Spanish starting with the same word.", function() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this test fails (because no.
is an abbreviation), hence the xit
.
A merge conflict has been detected for the proposed code changes in this PR. Please resolve the conflict by either rebasing the PR or merging in changes from the base branch. |
This PR is ready for a first round of review. I'll admit that I haven't been able to test the functionality on different editors pretty deeply, but as it's pretty straightforward I don't expect many problems. |
Context
Summary
This PR can be summarized in the following changelog entry:
Relevant technical choices:
Node
class.Test instructions
Test instructions for the acceptance test before the PR gets merged
This PR can be acceptance tested by following these steps:
Relevant test scenarios
Test instructions for QA when the code is in the RC
QA can test this PR by following these steps:
Impact check
This PR affects the following parts of the plugin, which may require extra testing:
UI changes
Other environments
[shopify-seo]
, added test instructions for Shopify and attached theShopify
label to this PR.Documentation
Quality assurance
Innovation
innovation
label.Fixes https://github.com/Yoast/lingo-other-tasks/issues/173