JoyMIDI Linter Fixes #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This config file is used by codefactor.io and can be used to override some of the default settings. The default config has been obtained from: https://github.com/codefactor-io/default-configs/blob/master/.eslintrc.json
Previously, this setting led to a lot of false positives in out
controller scripts, e.g.:
'group' is defined but never used.
Found in res\controllers\KANE_QuNeo_scripts.js:1120
KANE_QuNeo.scrollPlaylist = function (channel, control, value, status, group) {
The .eslintrc.yaml for novation-launchpad has issues with recent
versions of eslint and requires installation of custom npm packages.
$ eslint .
Oops! Something went wrong! :(
ESLint: 6.8.0.
ESLint couldn't find the config "standard" to extend from. Please check that the name of the config is correct.
The config "standard" was referenced from the config file in "/data/jan/Projects/mixxx/res/controllers/novation-launchpad/.eslintrc.yaml".
If you still have problems, please stop by https://gitter.im/eslint/eslint to chat with the team.
These shouldn't cause a lot of linter issues in our existing codebase (if any). There's no reason why they shouldn't be enabled IMHO.
Although Promises aren't support by Qt Script anyway, some scripts in the res/controllers directory are using Promises anyway (i.e. the Novation Launchpad scripts). So in any case it doesn't hurt to enable this rule.
Add eslintrc for CodeFactor.io
.eslintrc.json: Add more rules regarding spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some remaining linter issues in PR mixxxdj#2425.