Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JoyMIDI Linter Fixes #1

Merged
merged 25 commits into from
Jan 20, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
15669f6
.eslintrc.json: Add codefactor.io's default eslint config
Holzhaus Jan 14, 2020
f835ac1
.eslintrc.json: Disable no-unused-vars for function arguments
Holzhaus Jan 14, 2020
6013f2c
.eslintrc.json: Set up env for QScript controller mappings
Holzhaus Jan 14, 2020
33f0f5c
.eslintrc.json: Configure eslint to use honor Mixxx coding conventions
Holzhaus Jan 14, 2020
a986828
.eslintrc.json: Add '_' and 'color' to list of globals
Holzhaus Jan 14, 2020
dc97e30
.eslintrc.json: Re-enable some recommended linter rules
Holzhaus Jan 14, 2020
251fd4f
.eslintrc.json: Reduce global variable scope to certain source dirs
Holzhaus Jan 14, 2020
a254f88
.eslintignore: Ignore the res/controllers/lodash.mixxx.js script
Holzhaus Jan 14, 2020
b738aeb
res/controllers/novation-launchpad: Remove .eslintrc.yaml
Holzhaus Jan 14, 2020
6ec5a2f
.eslintrc.json: Only ignore unused args if they start with an underscore
Holzhaus Jan 17, 2020
64658eb
.eslintrc.json: Re-enabled remaining recommended eslint rules
Holzhaus Jan 17, 2020
ccdd31b
.eslintrc.json: Enable require-atomic-updates rule
Holzhaus Jan 17, 2020
0af45d0
.eslintrc.json: Order rules alphabetically
Holzhaus Jan 17, 2020
3cf0bed
.eslintrc.json: Reduce camelcase severity to "warn"
Holzhaus Jan 17, 2020
87d47b7
.eslintrc.json: Enforce consistent "dot-location" style
Holzhaus Jan 17, 2020
63c86fe
.eslintrc.json: Add even more code style rules
Holzhaus Jan 17, 2020
78a6cc2
.eslintrc.json: Allow opening/closing braces for block on same line
Holzhaus Jan 17, 2020
97b3b92
.eslintrc.json: Add more rules regarding key spacing and trailing spaces
Holzhaus Jan 17, 2020
14c7242
.eslintrc.json: Disallow unneeded ternary ops and spaces before func …
Holzhaus Jan 19, 2020
c3242c2
Merge pull request #2442 from Holzhaus/eslint-config
Holzhaus Jan 19, 2020
819be4a
.eslintrc.json: Add more rules regarding spacing
Holzhaus Jan 19, 2020
725c02e
Merge pull request #2457 from Holzhaus/eslint-config-refined
uklotzde Jan 19, 2020
9eb5e41
Merge remote-tracking branch 'upstream/2.2' into HEAD
Holzhaus Jan 20, 2020
1ce6938
Soundless joyMIDI: Auto-fix eslint issues
Holzhaus Jan 20, 2020
833a3fa
Soundless joyMIDI: Fix remaining issues
Holzhaus Jan 20, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
res/controllers/lodash.mixxx.js
51 changes: 51 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
{
"extends": "eslint:recommended",
"parserOptions": {
"ecmaVersion": 5,
"sourceType": "script"
},
"rules": {
"array-bracket-spacing" : "warn",
"block-spacing": "warn",
"brace-style": ["warn", "1tbs", {
"allowSingleLine": true
}],
"camelcase": "warn",
"comma-spacing": "warn",
"computed-property-spacing" : ["warn", "never", {
"enforceForClassMembers": true
}],
"dot-location": "warn",
"eqeqeq": ["error", "always"],
"func-style": ["error", "expression", {
"allowArrowFunctions": true
}],
"key-spacing": "warn",
"keyword-spacing": "warn",
"linebreak-style": ["warn", "unix"],
"no-trailing-spaces": "warn",
"no-unneeded-ternary": ["warn", {
"defaultAssignment": false
}],
"no-unused-vars": ["error", {
"argsIgnorePattern": "^_"
}],
"object-curly-newline" : ["warn", {
"consistent": true,
"multiline": true
}],
"object-curly-spacing" : "warn",
"quotes": ["warn", "double"],
"require-atomic-updates": "error",
"semi": "warn",
"semi-spacing": "warn",
"space-before-blocks": ["warn", "always"],
"space-before-function-paren": ["warn", "never"],
"space-in-parens": "warn"
},
"globals": {
"console": "writable",
"svg": "writable",
"print": "readonly"
}
}
10 changes: 10 additions & 0 deletions res/controllers/.eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
{
"globals": {
"_": "readonly",
"color": "readonly",
"components": "readonly",
"engine": "readonly",
"midi": "readonly",
"script": "readonly"
}
}
Loading