Add missing translations #3408
Merged
Add missing translations #3408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danmoseley
reviewed
Apr 4, 2024
| <value>contains</value> | ||
| </data> | ||
| <data name="LogNotContains" xml:space="preserve"> | ||
| <value>not contains</value> |
There was a problem hiding this comment.
just curious, is a fragment like this localizable (at least without more context)? I understand translating complete sentences, and maybe headings like "Level:" but in past projects localizer folks have asked me context here in comments for localizers explaining whether this stands alone, or needs to grammatically agree with something, or corresponds to singular or plural things...
IDK, just curious
There was a problem hiding this comment.
Yes, it is localizable 😄 see the note right below
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kvenkatrajan
approved these changes
Apr 9, 2024
|
Should this be in release/8.0? for example |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8873353136 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add missing translations for structured logs page's "Level:" and the contains and not contains strings.
Fixes #2877
Microsoft Reviewers: Open in CodeFlow