-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Add missing translations #4004
Conversation
@kvenkatrajan @adamint could you review |
Somehow the `.Designer.cs` files for `Columns.resx` and `Logs.resx` were inverted. Any change to one of these files would result in compilation errors due to duplicate classes. This change renames the files so that future regeneration won't hit problems.
Seems ok from manual testing. Just tested English. I remember that this PR had a regression where the Logs and Columns generated code was mixed up for some reason. I also cherry-picked that fix from #3632 |
Thanks James. |
We were missing the translations 😄 .. fixed |
Might be worth someone flipping their locale and exercising the dashboard just to look for any places we eg don't pull from resources. |
@danmoseley yes we do cover non-ENU configurations as well. @v-sherryfan @v-elenafeng fyi on this incoming fix for 8.0 GA. When verifying this, please test with non-ENU configurations too. |
I raised this in the original issue - #2877 - graph still isn't translated: Edit: However it is translated in Spanish: Maybe there isn't a chinese word for graph 🤷 |
Thanks @danmoseley , @JamesNK , @balachir
Was this in a separate PR? How was this fixed?
I have opened a ticket for this one to confirm : https://ceapex.visualstudio.com/CEINTL/_workitems/edit/968065 |
I just copied the xlf files from main. |
Ah ok so the translation came into main after we created the original PR. Ok makes sense. Thanks @danmoseley |
thanks, note they'll still see #4020. Question is is there anything else. |
Backport of #3408 to release/8.0
/cc @JamesNK @adamint
Customer Impact
Some UI elements on structured logs page aren't translated.
Testing
Manual testing on the branch. English translation continues to work:
and
Risk
Low
Regression?
No
Microsoft Reviewers: Open in CodeFlow