Add SuppressFinalPackageVersion to libraries we don't plan to ship stable yet #3668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…able yet - Aspire.Hosting.AWS - OpenAI - EventHubs Part of dotnet#2541
eerhardt
requested review from
radical,
davidfowl,
DamianEdwards,
mitchdenny,
sebastienros and
joperezr
dotnet-issue-labeler
bot
added
the
area-integrations
| @@ -3,6 +3,8 @@ | |||
| <PropertyGroup> | |||
| <TargetFramework>$(NetCurrent)</TargetFramework> | |||
| <IsPackable>true</IsPackable> | |||
| <!-- This library needs more bake time until it can ship stable. --> | |||
| <SuppressFinalPackageVersion>true</SuppressFinalPackageVersion> | |||
There was a problem hiding this comment.
Just for my own understanding as this is the first time I have seen this one
sebastienros
approved these changes
Apr 12, 2024
|
Why not Open AI? |
The underlying client library isn't stable. https://www.nuget.org/packages/Azure.AI.OpenAI/ |
radical
approved these changes
Apr 15, 2024
|
Merging. If there are more packages that should stay pre-release we can add them later. |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8692901723 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2541
FYI - @normj
Microsoft Reviewers: Open in CodeFlow