-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new(engine): enforce unique exceptions names #3134
Conversation
This PR may bring feature or behavior changes in the Falco engine and may require the engine version to be bumped. Please double check userspace/engine/falco_engine_version.h file. See versioning for FALCO_ENGINE_VERSION. /hold |
5f9ff50
to
5319505
Compare
LGTM label has been added. Git tree hash: 244d440edb2e293be72260047f16d6273885de0a
|
Already bumped. |
@mrgian can you rebase to fix conflicts? |
Signed-off-by: Gianmatteo Palmieri <[email protected]>
Signed-off-by: Gianmatteo Palmieri <[email protected]>
Signed-off-by: Gianmatteo Palmieri <[email protected]>
5319505
to
36be2b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
LGTM label has been added. Git tree hash: a16401be9b2826992037d6a0adb403aecb895751
|
Rebased! |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: FedeDP, leogr, mrgian The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
/kind bug
/kind feature
Any specific area of the project related to this PR?
/area engine
/area tests
What this PR does / why we need it:
Does't allow multiple exceptions definitions in the same rule object.
Example:
In this example it's not clear where the new values are appended.
Which issue(s) this PR fixes: #2279
Fixes #2279
Special notes for your reviewer:
Does this PR introduce a user-facing change?: