new(engine): enforce unique exceptions names

unit_tests/engine/test_rule_loader.cpp

@@ -958,4 +958,29 @@ TEST_F(test_falco_engine, exceptions_override_no_values)
 
   ASSERT_TRUE(load_rules(rules_content, "rules.yaml"));
   ASSERT_TRUE(check_warning_message("Overriding/appending exception with no values"));
+}
+
+TEST_F(test_falco_engine, exceptions_names_not_unique)
+{
+    std::string rules_content = R"END(
+- rule: test_rule
+  desc: test rule
+  condition: proc.cmdline contains curl
+  output: command=%proc.cmdline
+  priority: INFO
+  exceptions:
+    - name: test_exception
+      fields: [proc.cmdline]
+      comps: [contains]
+      values:
+        - [curl 127.0.0.1]
+    - name: test_exception
+      fields: [proc.cmdline]
+      comps: [endswith]
+      values:
+        - [curl 127.0.0.1]
+)END";
+
+  ASSERT_FALSE(load_rules(rules_content, "rules.yaml"));
+  ASSERT_TRUE(check_error_message("Exceptions names in the same object must be unique"));
 }

userspace/engine/falco_engine_version.h

@@ -20,7 +20,7 @@ limitations under the License.
 
 // The version of this Falco engine
 #define FALCO_ENGINE_VERSION_MAJOR 0
-#define FALCO_ENGINE_VERSION_MINOR 38
+#define FALCO_ENGINE_VERSION_MINOR 39
 #define FALCO_ENGINE_VERSION_PATCH 0
 
 #define FALCO_ENGINE_VERSION \

userspace/engine/rule_loader_reader.cpp

@@ -316,6 +316,13 @@ static void read_rule_exceptions(
 		rule_loader::rule_exception_info v_ex(ex_ctx);
 		v_ex.name = name;
 
+		// Check if an exception with the same name has already been defined
+		for (auto &exception : exceptions)
+		{
+			THROW((v_ex.name == exception.name),
+			       "Exceptions names in the same object must be unique", ex_ctx);
+		}
+
 		// note: the legacy lua loader used to throw a "xxx must strings" error
 
 		// fields are optional when append is true