This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
It allows setting two environment variables (DEP_CMD_TIMEOUT and DEP_EXP_CMD_TIMEOUT) to control the timeout for external commands to finish.
On slow machines or slow setups (remote FS, or in my case ubuntu on windows) the 10s default are not sufficient.
The change will make dep tolerate incomplete deletions of vendor directories in dependant packages. This is also an attempt to support slower operations.
Do you need help or clarification on anything?
Where should documentation go?
Which issue(s) does this PR fix?
It uses an idea presented in #1065 to circumvent the problem shown there. Does that count as a fix?