Skip to content
This repository has been archived by the owner on Sep 9, 2020. It is now read-only.

[WIP] support slow OS commands. #1085

Closed
wants to merge 5 commits into from
Closed

[WIP] support slow OS commands. #1085

wants to merge 5 commits into from

Conversation

cypherfox
Copy link

What does this do / why do we need it?

It allows setting two environment variables (DEP_CMD_TIMEOUT and DEP_EXP_CMD_TIMEOUT) to control the timeout for external commands to finish.
On slow machines or slow setups (remote FS, or in my case ubuntu on windows) the 10s default are not sufficient.

The change will make dep tolerate incomplete deletions of vendor directories in dependant packages. This is also an attempt to support slower operations.

Do you need help or clarification on anything?

Where should documentation go?

Which issue(s) does this PR fix?

It uses an idea presented in #1065 to circumvent the problem shown there. Does that count as a fix?

@cypherfox cypherfox requested a review from sdboyer as a code owner August 29, 2017 14:58
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@cypherfox
Copy link
Author

I signed the CLA

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@sdboyer
Copy link
Member

sdboyer commented Aug 29, 2017

i think this is the same as #1028, no?

@cypherfox
Copy link
Author

It is almost the same. While I have similar changes for setting the timeout via env-vars, I also included a toleration for the OS not deleting a directory quickly enough.

I will separate the two and add another PR

@cypherfox cypherfox closed this Aug 29, 2017
@sdboyer
Copy link
Member

sdboyer commented Aug 29, 2017

thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants