This repository has been archived by the owner on Sep 9, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
Will skip failed calls to removeAll() when removing the vendor directories in loaded packages.
If the removeAll fails, the whole dep ensure run will fail and there is no method to work around as dep will start over each time.
What should your reviewer look out for in this PR?
The current code simply ignores the failure to delete the vendor dir. Should it retry? how often?
Which issue(s) does this PR fix?
It is a extension of the Problems discussed in #1087
This is an update to #1085