Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor First Third #546

Merged
merged 11 commits into from
Jan 14, 2022
Merged

Conversation

JJamesWWang
Copy link
Member

@JJamesWWang JJamesWWang commented Jan 14, 2022

Ideally I'd do first half, but there's a change that would mess up the staging URL in the next third

@JJamesWWang JJamesWWang changed the title Merge pull request #463 from JJamesWWang/refactor-authpipe Refactor First Half Jan 14, 2022
@JJamesWWang JJamesWWang changed the title Refactor First Half Refactor First Third Jan 14, 2022
@JJamesWWang JJamesWWang marked this pull request as ready for review January 14, 2022 15:48
Copy link
Collaborator

@yesterd3v yesterd3v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@JJamesWWang JJamesWWang merged commit afaaef8 into jhuopensource:prod Jan 14, 2022
JJamesWWang added a commit to JJamesWWang/semesterly that referenced this pull request Jan 15, 2022
JJamesWWang added a commit that referenced this pull request Jan 15, 2022
Merge pull request #546 from JJamesWWang/refactor-first-half
JJamesWWang added a commit to JJamesWWang/semesterly that referenced this pull request Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants