Skip to content
This repository has been archived by the owner on May 6, 2022. It is now read-only.

Bump kube 1.15 #2683

Merged
merged 1 commit into from
Aug 13, 2019
Merged

Bump kube 1.15 #2683

merged 1 commit into from
Aug 13, 2019

Conversation

jberkhahn
Copy link
Contributor

No description provided.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 2, 2019
@jberkhahn
Copy link
Contributor Author

/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 2, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkhahn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 2, 2019
@jberkhahn jberkhahn force-pushed the bump_kube_1.15 branch 5 times, most recently from 1b4cc80 to 156d857 Compare August 5, 2019 18:45
@jberkhahn
Copy link
Contributor Author

/retest

@jberkhahn jberkhahn force-pushed the bump_kube_1.15 branch 3 times, most recently from a372332 to 0a0dec6 Compare August 5, 2019 21:25
@jberkhahn
Copy link
Contributor Author

/retest

@jberkhahn
Copy link
Contributor Author

/test pull-service-catalog-integration

@jberkhahn
Copy link
Contributor Author

/retest

MHBauer
MHBauer reviewed Aug 9, 2019
View reviewed changes
vendor/github.com/pmorie/go-open-service-broker-client/v2/fake/fake.go Outdated
if r == nil {
return nil, UnexpectedActionError()
}
if req.ServiceID == "" || req.PlanID == "" || req.OrganizationGUID == "" || req.SpaceGUID == "" {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New validation was added. Need to make sure all the fakes have these fields.

MHBauer
MHBauer reviewed Aug 9, 2019
View reviewed changes
Gopkg.lock Outdated
name = "github.com/pmorie/go-open-service-broker-client"
packages = [
"v2",
"v2/fake",
"v2/generator",
]
pruneopts = "NUT"
revision = "6988c0983446576f2cefc90112028a66e6137233"
revision = "a894d21a6d93b2b01b434b2226d806cc1240f79d"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't be updating this anyway.

I can see that the project in Toml is dependent on 'master'. It should be locked down, and versioned.

@MHBauer
Copy link
Contributor

MHBauer commented Aug 9, 2019 •
edited
Loading

Do the update of the library in a separate PR.
Lock it to some specific version/revision rather than the master branch.

For this PR, back out the change to the library, and it should work as-is.

@jberkhahn
Copy link
Contributor Author

/test pull-service-catalog-integration

@jberkhahn jberkhahn force-pushed the bump_kube_1.15 branch 2 times, most recently from 71333a8 to b812a1b Compare August 9, 2019 23:58
@jberkhahn
Copy link
Contributor Author

/test pull-service-catalog-xbuild

1 similar comment
@mszostok
Copy link
Contributor

/test pull-service-catalog-xbuild

mszostok
mszostok approved these changes Aug 12, 2019
View reviewed changes
Copy link
Contributor

@mszostok mszostok left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

but I agree with @MHBauer that "github.com/pmorie/go-open-service-broker-client" should be locked with some revision and maybe with a comment about created #2687 issue. Thanks to that other people will not run into the same issue as you had

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@MHBauer
Copy link
Contributor

MHBauer commented Aug 12, 2019

forgotten comment, based on discussion on Friday

The fake Namespace test-namespace is being added, multiple times, to the fakeKubeClinet fake, and I'm not sure where it's coming from.

@jberkhahn
Bump kubernetes to 1.15
8212f20 
- rewrite GetStorage calls in pkg/registry/servicecatalog
- FeatureGate imports updated to new package
- change plugin/pkg/admission test calls to NewAttributeRecord()
- bump github.com/google/gofuzz to 1.0.0 to comply with apimachinery
- enable tls 13 in Makefile
@k8s-ci-robot k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2019
@jberkhahn jberkhahn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 12, 2019
@jberkhahn
Copy link
Contributor Author

had to force push up to add a real commit message. this should be good to merge now

@jberkhahn
Copy link
Contributor Author

/test pull-service-catalog-xbuild

@jberkhahn
Copy link
Contributor Author

/retest

@mszostok
Copy link
Contributor

/lgtm

but still with the same comment: #2683 (review)

@k8s-ci-robot k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2019
@k8s-ci-robot k8s-ci-robot merged commit ebfe762 into kubernetes-retired:master Aug 13, 2019
@mszostok mszostok mentioned this pull request Aug 16, 2019
Closed
@MHBauer MHBauer mentioned this pull request Aug 26, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MHBauer MHBauer MHBauer left review comments

@mszostok mszostok mszostok approved these changes

Assignees

@mszostok mszostok

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jberkhahn @k8s-ci-robot @MHBauer @mszostok