Bump OSB client lib #2689

jberkhahn · 2019-08-15T21:37:43Z

Also lock version of the osb client lib

jberkhahn · 2019-08-15T21:37:52Z

/hold

k8s-ci-robot · 2019-08-15T21:38:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jberkhahn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [jberkhahn]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

MHBauer

Still not sure where the original test-namespace is coming from.

¯_(ツ)_/¯

/lgtm

MHBauer · 2019-08-15T23:36:52Z

test/integration/controller_test.go

+			ObjectMeta: metav1.ObjectMeta{
+				Name:      namespace,
+				Namespace: namespace,
+				UID:       "testnamespace1234",


The UID is specifically what was missing from the current implementation.

MHBauer · 2019-08-15T23:37:14Z

vendor/github.com/pmorie/go-open-service-broker-client/v2/fake/fake.go

 	if r == nil {
 		return nil, UnexpectedActionError()
 	}
+	if req.ServiceID == "" || req.PlanID == "" || req.OrganizationGUID == "" || req.SpaceGUID == "" {
+		return nil, RequiredFieldsMissingError()


we're trying to avoid hitting this check.

mszostok · 2019-08-16T11:37:49Z

test/integration/controller_test.go

@@ -748,6 +748,7 @@ func newControllerTestTestController(ct *controllerTest) (
 	// create a fake kube client
 	fakeKubeClient := &fake.Clientset{}
 	fakeKubeClient.Lock()
+	prependGetNamespaceReaction(fakeKubeClient, "test-namespace")


use const testNamespace

it's already defined https://github.com/kubernetes-sigs/service-catalog/blob/f3b2f3ff22a819b1f6bf3915d6ab32315433d94e/test/integration/controller_test.go#L59

mszostok · 2019-08-16T11:46:05Z

Gopkg.lock

  name = "github.com/pmorie/go-open-service-broker-client"
  packages = [
    "v2",
    "v2/fake",
    "v2/generator",
  ]
  pruneopts = "NUT"
-  revision = "6988c0983446576f2cefc90112028a66e6137233"
+  revision = "a894d21a6d93b2b01b434b2226d806cc1240f79d"


you should lock that revision in Gopkg.toml file,

[[constraint]] name = "github.com/pmorie/go-open-service-broker-client" revision = "a894d21a6d93b2b01b434b2226d806cc1240f79d"

thanks to that executing dep ensure -v will not replace that automatically with new version in the future.

mszostok · 2019-08-16T12:00:16Z

@MHBauer what u mean by saying "Still not sure where the original test-namespace is coming from."?

mszostok · 2019-08-16T12:00:27Z

/test pull-service-catalog-integration

mszostok · 2019-08-16T13:26:20Z

test/integration/controller_test.go

+			ObjectMeta: metav1.ObjectMeta{
+				Name:      namespace,
+				Namespace: namespace,
+				UID:       "testnamespace1234",


you need to do that also here:
https://github.com/kubernetes-sigs/service-catalog/blob/master/pkg/controller/case_test.go#L87-L91

sth like:

import "k8s.io/apimachinery/pkg/util/uuid" k8sClient.CoreV1().Namespaces().Create(&corev1.Namespace{ ObjectMeta: metav1.ObjectMeta{ Name: testNamespace, UID: uuid.NewUUID(), // fake clientset doesn't duplicate server-side behavior like uid assignment }, })

MHBauer · 2019-08-26T21:38:26Z

@mszostok while debugging #2683 I printed out the namespaces when they were being searched, and "test-namespace" was always present, and an instance was added on each iteration. I did not track down where that was coming from.

mszostok · 2019-08-29T23:22:20Z

pkg/controller/case_test.go

@@ -25,6 +25,9 @@ import (
 	"testing"
 	"time"

+	"sync"
+
+	"github.com/google/uuid"


Suggested change

"github.com/google/uuid"

"k8s.io/apimachinery/pkg/util/uuid"

jberkhahn · 2019-08-29T23:43:51Z

/test pull-build-all-images-for-ppc64le

- lock dependency version to a894d21a6d93b2b01b434b2226d806cc1240f79d

jberkhahn · 2019-08-30T23:54:26Z

/test pull-build-all-images-for-ppc64le

jberkhahn · 2019-09-03T20:28:20Z

/test pull-build-all-images-for-ppc64le

mszostok · 2019-09-03T20:57:06Z

/lgtm

k8s-ci-robot · 2019-09-03T21:07:10Z

@jberkhahn: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-service-catalog-integration	`f3b2f3f`	link	`/test pull-service-catalog-integration`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 15, 2019

k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2019

k8s-ci-robot requested review from MHBauer and mszostok August 15, 2019 21:38

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2019

jberkhahn force-pushed the bump_osb_client branch from 7a60c96 to f3b2f3f Compare August 15, 2019 23:27

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Aug 15, 2019

MHBauer approved these changes Aug 15, 2019

View reviewed changes

k8s-ci-robot assigned MHBauer Aug 15, 2019

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 15, 2019

mszostok reviewed Aug 16, 2019

View reviewed changes

mszostok mentioned this pull request Aug 21, 2019

bump pmorie/go-open-service-broker-client #2687

Closed

jberkhahn force-pushed the bump_osb_client branch from f3b2f3f to 8680980 Compare August 29, 2019 23:05

k8s-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Aug 29, 2019

mszostok reviewed Aug 29, 2019

View reviewed changes

jberkhahn force-pushed the bump_osb_client branch from 8680980 to 8884038 Compare August 29, 2019 23:32

Bump github.com/pmorie/go-open-service-broker-client dependency

1e3f56e

- lock dependency version to a894d21a6d93b2b01b434b2226d806cc1240f79d

jberkhahn force-pushed the bump_osb_client branch from 8884038 to 1e3f56e Compare August 30, 2019 18:33

jberkhahn removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 30, 2019

k8s-ci-robot assigned mszostok Sep 3, 2019

k8s-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 3, 2019

k8s-ci-robot merged commit 764c1be into kubernetes-retired:master Sep 3, 2019

mszostok mentioned this pull request Sep 27, 2019

Bump Service Catalog release to 0.3.0-beta.0 #2715

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump OSB client lib #2689

Bump OSB client lib #2689

jberkhahn commented Aug 15, 2019

jberkhahn commented Aug 15, 2019

k8s-ci-robot commented Aug 15, 2019

MHBauer left a comment

MHBauer Aug 15, 2019

MHBauer Aug 15, 2019

mszostok Aug 16, 2019

mszostok Aug 16, 2019

mszostok commented Aug 16, 2019

mszostok commented Aug 16, 2019

mszostok Aug 16, 2019 •

edited

Loading

MHBauer commented Aug 26, 2019

mszostok Aug 29, 2019

jberkhahn Aug 29, 2019

jberkhahn commented Aug 29, 2019

jberkhahn commented Aug 30, 2019

jberkhahn commented Sep 3, 2019

mszostok commented Sep 3, 2019

k8s-ci-robot commented Sep 3, 2019 •

edited

Loading

	"github.com/google/uuid"
	"k8s.io/apimachinery/pkg/util/uuid"

Bump OSB client lib #2689

Bump OSB client lib #2689

Conversation

jberkhahn commented Aug 15, 2019

jberkhahn commented Aug 15, 2019

k8s-ci-robot commented Aug 15, 2019

MHBauer left a comment

Choose a reason for hiding this comment

MHBauer Aug 15, 2019

Choose a reason for hiding this comment

MHBauer Aug 15, 2019

Choose a reason for hiding this comment

mszostok Aug 16, 2019

Choose a reason for hiding this comment

mszostok Aug 16, 2019

Choose a reason for hiding this comment

mszostok commented Aug 16, 2019

mszostok commented Aug 16, 2019

mszostok Aug 16, 2019 • edited Loading

Choose a reason for hiding this comment

MHBauer commented Aug 26, 2019

mszostok Aug 29, 2019

Choose a reason for hiding this comment

jberkhahn Aug 29, 2019

Choose a reason for hiding this comment

jberkhahn commented Aug 29, 2019

jberkhahn commented Aug 30, 2019

jberkhahn commented Sep 3, 2019

mszostok commented Sep 3, 2019

k8s-ci-robot commented Sep 3, 2019 • edited Loading

mszostok Aug 16, 2019 •

edited

Loading

k8s-ci-robot commented Sep 3, 2019 •

edited

Loading