Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help widget fix #2691

Merged
merged 6 commits into from
Dec 9, 2020
+91 −136
Merged

Help widget fix #2691

Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
a9a7148
Fixes the help widget
ricknjacky Dec 7, 2020
bfcdf71
minor ui changes
ricknjacky Dec 7, 2020
c58a458
fixing the context anomaly
ricknjacky Dec 7, 2020
0a183b1
positioning fix
ricknjacky Dec 8, 2020
0fa7aa8
Center help widget after DOM elements are created
meganindya Dec 9, 2020
1e7ba23
Format code
meganindya Dec 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions js/widgets/help.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ function HelpWidget() {
this.isOpen = true;

let widgetWindow = window.widgetWindows.windowFor(this, "help", "help");
widgetWindow.getWidgetBody().style.overflowY = "auto";
widgetWindow.getWidgetBody().style.maxHeight = "500px";
this.widgetWindow = widgetWindow;
widgetWindow.clear();
widgetWindow.show();
Expand All @@ -29,12 +31,10 @@ function HelpWidget() {
this.isOpen = false;
this.destroy();
};

// Position the widget and make it visible.
this._helpDiv = document.createElement("div");

// Give the DOM time to create the div.

setTimeout(() => {
this._setup(blocks);
}, 100);
Expand All @@ -47,6 +47,8 @@ function HelpWidget() {

this._helpDiv.style.width = iconSize * 2 + 425 + "px";
this._helpDiv.style.backgroundColor = "#e8e8e8";
// this._helpDiv.style.maxHeight = "100%";
// this._helpDiv.style.overflowY = "auto";
this._helpDiv.innerHTML =
'<div id="right-arrow" class="hover" tabindex="-1"></div><div id="left-arrow" class="hover" tabindex="-1"></div><div id="helpButtonsDiv" tabindex="-1"></div><div id="helpBodyDiv" tabindex="-1"></div>';

Expand Down