Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help widget fix #2691

Merged
merged 6 commits into from
Dec 9, 2020
Merged

Help widget fix #2691

merged 6 commits into from
Dec 9, 2020

Conversation

ricknjacky
Copy link
Member

fixes #2690

post changes, the behavior:-
help

@meganindya
Copy link
Member

Why the grey area at the bottom?

@ricknjacky
Copy link
Member Author

Why the grey area at the bottom?

It was because of the context ambiguity I had. Now it's resolved

@ricknjacky
Copy link
Member Author

imp

This, is the new behavior and there are no traces of the aforementioned gray area

@meganindya
Copy link
Member

Btw, the sendToCenter() isn't working properly along the y-axis. Probably it is evaluating height before the inner content is changed. See if you can fix it.

@ricknjacky
Copy link
Member Author

Btw, the sendToCenter() isn't working properly along the y-axis. Probably it is evaluating height before the inner content is changed. See if you can fix it.

Ig this is because of the hardcoded values here
Screenshot (412)

@meganindya
Copy link
Member

I don't think so. Those values are used only when a canvas isn't found. IG fRect.height is some anomalous value. Pls verify.

@ricknjacky
Copy link
Member Author

Yes, My bad.

Tweaked the positioning a little bit:-
gif

Does this match the expected behavior ?

@ricknjacky ricknjacky requested a review from meganindya December 8, 2020 10:23
@meganindya
Copy link
Member

That positioning was supposed to be done asynchronously because JavaScript DOM manipulation works asynchronously.

@meganindya meganindya merged commit d309667 into sugarlabs:master Dec 9, 2020
@ricknjacky ricknjacky deleted the helpWidgetFix branch December 9, 2020 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add scroll to help widget
2 participants